-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fixtures to parameterization #1210
Conversation
Not sure if it's worth it to load each h5 file every time. Also I left out |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1210 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 90 90
Lines 22643 22643
=======================================
+ Hits 21586 21587 +1
+ Misses 1057 1056 -1 |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -0.03 +/- 8.07 | -1.49e-04 +/- 4.36e-02 | 5.40e-01 +/- 2.5e-02 | 5.40e-01 +/- 3.6e-02 |
test_equilibrium_init_medres | -0.07 +/- 4.93 | -3.25e-03 +/- 2.16e-01 | 4.37e+00 +/- 1.4e-01 | 4.38e+00 +/- 1.6e-01 |
test_equilibrium_init_highres | +0.14 +/- 4.53 | +8.17e-03 +/- 2.59e-01 | 5.71e+00 +/- 2.1e-01 | 5.70e+00 +/- 1.6e-01 |
test_objective_compile_dshape_current | +1.29 +/- 1.68 | +5.03e-02 +/- 6.56e-02 | 3.95e+00 +/- 3.8e-02 | 3.90e+00 +/- 5.4e-02 |
test_objective_compute_dshape_current | +0.38 +/- 2.96 | +1.30e-05 +/- 1.03e-04 | 3.48e-03 +/- 8.7e-05 | 3.47e-03 +/- 5.5e-05 |
test_objective_jac_dshape_current | -7.26 +/- 8.20 | -3.21e-03 +/- 3.62e-03 | 4.10e-02 +/- 3.3e-03 | 4.42e-02 +/- 1.5e-03 |
test_perturb_2 | -0.02 +/- 1.82 | -3.74e-03 +/- 3.29e-01 | 1.81e+01 +/- 2.6e-01 | 1.81e+01 +/- 2.0e-01 |
test_proximal_freeb_jac | -0.67 +/- 1.81 | -5.11e-02 +/- 1.37e-01 | 7.55e+00 +/- 5.4e-02 | 7.60e+00 +/- 1.3e-01 |
test_solve_fixed_iter | -1.05 +/- 60.35 | -5.30e-02 +/- 3.03e+00 | 4.97e+00 +/- 2.1e+00 | 5.02e+00 +/- 2.2e+00 | |
("DummyCoilSet", "lsq-exact", "output_path_asym"), | ||
("DummyMixedCoilSet", "lsq-exact", "output_path"), | ||
], | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make the coilsets as conftest fixtures
I added a nested coil set fixture so it's working now. But, I still need to decide on whether we should save the h5 file in the fixture or if we should just return the coil set. |
close when #1362 is merged in, I think |
closing since #1362 solved this |
resolves #1104