Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fixtures to parameterization #1210

Closed
wants to merge 7 commits into from
Closed

add fixtures to parameterization #1210

wants to merge 7 commits into from

Conversation

kianorr
Copy link
Collaborator

@kianorr kianorr commented Aug 20, 2024

resolves #1104

@kianorr
Copy link
Collaborator Author

kianorr commented Aug 20, 2024

Not sure if it's worth it to load each h5 file every time.

Also I left out nested_coils = MixedCoilSet(sym_coils, mixed_coils, check_intersection=False) and spline_coil = mixed_coils.coils[-1].copy() because I couldn't think of a clean way to incorporate them yet.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (225d44e) to head (8ed8f64).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1210   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files          90       90           
  Lines       22643    22643           
=======================================
+ Hits        21586    21587    +1     
+ Misses       1057     1056    -1     

see 3 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Aug 21, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     -0.03 +/- 8.07     | -1.49e-04 +/- 4.36e-02 |  5.40e-01 +/- 2.5e-02  |  5.40e-01 +/- 3.6e-02  |
 test_equilibrium_init_medres            |     -0.07 +/- 4.93     | -3.25e-03 +/- 2.16e-01 |  4.37e+00 +/- 1.4e-01  |  4.38e+00 +/- 1.6e-01  |
 test_equilibrium_init_highres           |     +0.14 +/- 4.53     | +8.17e-03 +/- 2.59e-01 |  5.71e+00 +/- 2.1e-01  |  5.70e+00 +/- 1.6e-01  |
 test_objective_compile_dshape_current   |     +1.29 +/- 1.68     | +5.03e-02 +/- 6.56e-02 |  3.95e+00 +/- 3.8e-02  |  3.90e+00 +/- 5.4e-02  |
 test_objective_compute_dshape_current   |     +0.38 +/- 2.96     | +1.30e-05 +/- 1.03e-04 |  3.48e-03 +/- 8.7e-05  |  3.47e-03 +/- 5.5e-05  |
 test_objective_jac_dshape_current       |     -7.26 +/- 8.20     | -3.21e-03 +/- 3.62e-03 |  4.10e-02 +/- 3.3e-03  |  4.42e-02 +/- 1.5e-03  |
 test_perturb_2                          |     -0.02 +/- 1.82     | -3.74e-03 +/- 3.29e-01 |  1.81e+01 +/- 2.6e-01  |  1.81e+01 +/- 2.0e-01  |
 test_proximal_freeb_jac                 |     -0.67 +/- 1.81     | -5.11e-02 +/- 1.37e-01 |  7.55e+00 +/- 5.4e-02  |  7.60e+00 +/- 1.3e-01  |
 test_solve_fixed_iter                   |     -1.05 +/- 60.35    | -5.30e-02 +/- 3.03e+00 |  4.97e+00 +/- 2.1e+00  |  5.02e+00 +/- 2.2e+00  |

("DummyCoilSet", "lsq-exact", "output_path_asym"),
("DummyMixedCoilSet", "lsq-exact", "output_path"),
],
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the coilsets as conftest fixtures

@kianorr
Copy link
Collaborator Author

kianorr commented Aug 29, 2024

I added a nested coil set fixture so it's working now. But, I still need to decide on whether we should save the h5 file in the fixture or if we should just return the coil set.

@dpanici
Copy link
Collaborator

dpanici commented Nov 13, 2024

close when #1362 is merged in, I think

@YigitElma
Copy link
Collaborator

closing since #1362 solved this

@YigitElma YigitElma closed this Nov 20, 2024
@YigitElma YigitElma deleted the ko/param-coil-test branch November 20, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants