Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update boozer fit for general toroidal angle #1179

Merged
merged 7 commits into from
Aug 17, 2024
Merged

Conversation

unalmis
Copy link
Collaborator

@unalmis unalmis commented Aug 12, 2024

sqrt_g_B is generalized in upstream PR, this one just update B_zeta_mn

@unalmis unalmis changed the base branch from master to ku/angles August 12, 2024 22:17
@unalmis unalmis added bug fix Something was fixed and removed bug fix Something was fixed labels Aug 12, 2024
@unalmis unalmis added the low priority Nice to have, but not needed right away label Aug 12, 2024
@unalmis unalmis changed the base branch from ku/angles to rc/toroidal_angle August 12, 2024 23:14
@unalmis unalmis changed the title Ku/fix boozer update boozer fit for general toroidal angle Aug 12, 2024
Copy link
Contributor

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +7.95 +/- 8.98     | +4.17e-02 +/- 4.71e-02 |  5.67e-01 +/- 4.5e-02  |  5.25e-01 +/- 1.5e-02  |
 test_build_transform_fft_midres         |     +2.65 +/- 7.69     | +1.63e-02 +/- 4.73e-02 |  6.32e-01 +/- 4.5e-02  |  6.16e-01 +/- 1.3e-02  |
 test_build_transform_fft_highres        |     +1.06 +/- 3.36     | +1.09e-02 +/- 3.45e-02 |  1.04e+00 +/- 2.9e-02  |  1.03e+00 +/- 1.8e-02  |
 test_equilibrium_init_lowres            |     -1.79 +/- 8.12     | -6.99e-02 +/- 3.16e-01 |  3.83e+00 +/- 2.0e-01  |  3.90e+00 +/- 2.4e-01  |
 test_equilibrium_init_medres            |     +2.92 +/- 4.20     | +1.22e-01 +/- 1.75e-01 |  4.29e+00 +/- 1.3e-01  |  4.17e+00 +/- 1.2e-01  |
 test_equilibrium_init_highres           |     -1.33 +/- 4.18     | -7.49e-02 +/- 2.36e-01 |  5.57e+00 +/- 6.1e-02  |  5.64e+00 +/- 2.3e-01  |
 test_objective_compile_dshape_current   |     -2.41 +/- 0.93     | -9.50e-02 +/- 3.67e-02 |  3.85e+00 +/- 3.0e-02  |  3.95e+00 +/- 2.1e-02  |
 test_objective_compile_atf              |     +2.48 +/- 5.13     | +2.12e-01 +/- 4.39e-01 |  8.76e+00 +/- 4.0e-01  |  8.55e+00 +/- 1.9e-01  |
 test_objective_compute_dshape_current   |     -1.48 +/- 3.63     | -1.92e-05 +/- 4.69e-05 |  1.27e-03 +/- 3.6e-05  |  1.29e-03 +/- 3.0e-05  |
 test_objective_compute_atf              |     -1.97 +/- 4.97     | -8.51e-05 +/- 2.14e-04 |  4.23e-03 +/- 1.3e-04  |  4.31e-03 +/- 1.7e-04  |
 test_objective_jac_dshape_current       |     +1.58 +/- 8.56     | +5.89e-04 +/- 3.19e-03 |  3.79e-02 +/- 1.7e-03  |  3.73e-02 +/- 2.7e-03  |
 test_objective_jac_atf                  |     -3.42 +/- 2.92     | -6.66e-02 +/- 5.68e-02 |  1.88e+00 +/- 4.1e-02  |  1.95e+00 +/- 3.9e-02  |
 test_perturb_1                          |     +0.64 +/- 2.92     | +9.04e-02 +/- 4.13e-01 |  1.42e+01 +/- 3.4e-01  |  1.41e+01 +/- 2.4e-01  |
 test_perturb_2                          |     +0.32 +/- 3.32     | +6.11e-02 +/- 6.42e-01 |  1.94e+01 +/- 6.3e-01  |  1.94e+01 +/- 1.2e-01  |
 test_proximal_jac_atf                   |     -1.77 +/- 1.07     | -1.31e-01 +/- 7.99e-02 |  7.31e+00 +/- 6.9e-02  |  7.44e+00 +/- 4.1e-02  |
 test_proximal_freeb_compute             |     +1.35 +/- 0.78     | +2.41e-03 +/- 1.39e-03 |  1.80e-01 +/- 9.0e-04  |  1.78e-01 +/- 1.1e-03  |
 test_proximal_freeb_jac                 |     +0.62 +/- 2.12     | +4.61e-02 +/- 1.58e-01 |  7.49e+00 +/- 1.5e-01  |  7.45e+00 +/- 3.9e-02  |
 test_solve_fixed_iter                   |     -0.19 +/- 5.60     | -3.51e-02 +/- 1.04e+00 |  1.85e+01 +/- 8.0e-01  |  1.85e+01 +/- 6.5e-01  |

@unalmis unalmis changed the base branch from rc/toroidal_angle to ku/angles August 12, 2024 23:49
@unalmis unalmis marked this pull request as ready for review August 17, 2024 04:48
@unalmis unalmis merged commit 9270292 into ku/angles Aug 17, 2024
3 checks passed
@unalmis unalmis deleted the ku/fix_boozer branch August 17, 2024 04:49
@unalmis unalmis self-assigned this Aug 17, 2024
@unalmis unalmis removed the low priority Nice to have, but not needed right away label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boozer bug
1 participant