Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write VMEC input CURTOR #1019

Merged
merged 1 commit into from
May 15, 2024
Merged

write VMEC input CURTOR #1019

merged 1 commit into from
May 15, 2024

Conversation

ddudt
Copy link
Collaborator

@ddudt ddudt commented May 15, 2024

_Profile.__call__ returns an ndarray, but we need a float to print it as a string.

@ddudt ddudt added easy Short and simple to code or review EZ-review labels May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.94%. Comparing base (d9f4a8d) to head (33f4fbb).
Report is 1455 commits behind head on master.

Files with missing lines Patch % Lines
desc/vmec.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1019   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files          87       87           
  Lines       21699    21699           
=======================================
  Hits        20603    20603           
  Misses       1096     1096           
Files with missing lines Coverage Δ
desc/vmec.py 92.21% <0.00%> (ø)

Copy link
Contributor

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +3.50 +/- 5.13     | +1.81e-02 +/- 2.65e-02 |  5.35e-01 +/- 8.6e-03  |  5.17e-01 +/- 2.5e-02  |
 test_build_transform_fft_midres         |     +3.22 +/- 2.21     | +1.90e-02 +/- 1.30e-02 |  6.09e-01 +/- 1.0e-02  |  5.90e-01 +/- 8.2e-03  |
 test_build_transform_fft_highres        |     +0.81 +/- 2.62     | +8.07e-03 +/- 2.61e-02 |  1.00e+00 +/- 1.8e-02  |  9.95e-01 +/- 1.9e-02  |
 test_equilibrium_init_lowres            |     +3.90 +/- 4.16     | +1.53e-01 +/- 1.64e-01 |  4.09e+00 +/- 1.1e-01  |  3.93e+00 +/- 1.2e-01  |
 test_equilibrium_init_medres            |     +1.78 +/- 3.03     | +8.04e-02 +/- 1.37e-01 |  4.59e+00 +/- 9.2e-02  |  4.51e+00 +/- 1.0e-01  |
 test_equilibrium_init_highres           |     -1.32 +/- 5.03     | -8.28e-02 +/- 3.17e-01 |  6.21e+00 +/- 1.6e-01  |  6.29e+00 +/- 2.7e-01  |
 test_objective_compile_dshape_current   |     -2.52 +/- 2.04     | -9.38e-02 +/- 7.60e-02 |  3.62e+00 +/- 5.6e-02  |  3.72e+00 +/- 5.2e-02  |
 test_objective_compile_atf              |     -1.71 +/- 2.62     | -1.23e-01 +/- 1.88e-01 |  7.06e+00 +/- 9.7e-02  |  7.18e+00 +/- 1.6e-01  |
 test_objective_compute_dshape_current   |     -1.99 +/- 4.45     | -8.71e-05 +/- 1.95e-04 |  4.29e-03 +/- 1.5e-04  |  4.37e-03 +/- 1.2e-04  |
 test_objective_compute_atf              |     +0.44 +/- 2.51     | +8.15e-05 +/- 4.65e-04 |  1.86e-02 +/- 2.9e-04  |  1.85e-02 +/- 3.6e-04  |
 test_objective_jac_dshape_current       |     -2.89 +/- 6.73     | -1.18e-03 +/- 2.76e-03 |  3.98e-02 +/- 2.1e-03  |  4.10e-02 +/- 1.8e-03  |
 test_objective_jac_atf                  |     -1.60 +/- 2.45     | -2.94e-02 +/- 4.49e-02 |  1.80e+00 +/- 1.9e-02  |  1.83e+00 +/- 4.1e-02  |
 test_perturb_1                          |     -3.52 +/- 2.99     | -4.74e-01 +/- 4.03e-01 |  1.30e+01 +/- 3.2e-01  |  1.35e+01 +/- 2.4e-01  |
 test_perturb_2                          |     -3.60 +/- 3.18     | -6.69e-01 +/- 5.91e-01 |  1.79e+01 +/- 3.2e-01  |  1.86e+01 +/- 4.9e-01  |
 test_proximal_jac_atf                   |     -1.22 +/- 0.98     | -8.81e-02 +/- 7.11e-02 |  7.16e+00 +/- 5.3e-02  |  7.25e+00 +/- 4.7e-02  |
 test_proximal_freeb_compute             |     -0.90 +/- 1.28     | -1.78e-03 +/- 2.53e-03 |  1.96e-01 +/- 2.1e-03  |  1.98e-01 +/- 1.4e-03  |
 test_proximal_freeb_jac                 |     -4.44 +/- 4.67     | -3.48e-01 +/- 3.66e-01 |  7.49e+00 +/- 1.4e-01  |  7.84e+00 +/- 3.4e-01  |

@ddudt ddudt merged commit ef81903 into master May 15, 2024
21 of 22 checks passed
@ddudt ddudt deleted the dd/hotfix branch May 15, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Short and simple to code or review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants