Skip to content

Commit

Permalink
Add support for benchmark test from forks (#1345)
Browse files Browse the repository at this point in the history
Benchmark action requires write access for commenting which forks don't
have. This change makes the benchmark workflow coming from a fork run on
our CI and thus have proper access.

This shouldn't change the general permissions for fork repos, so someone
in the DESC team must still approve to test to run for such PRs.


https://github.com/thollander/actions-comment-pull-request?tab=readme-ov-file#permissions

- [ ] Make sure this is secure! Check from a fork repo!
  • Loading branch information
dpanici authored Nov 11, 2024
2 parents a9f9ae8 + 85b2cad commit 9d1d730
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
pull_request:
branches:
- master
pull_request_target:
types: [opened, synchronize]
workflow_dispatch:
inputs:
debug_enabled:
Expand Down

0 comments on commit 9d1d730

Please sign in to comment.