This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Fix #1210 and more issues by removing one level of "response" #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norbertschuler
changed the title
| @@ -36,11 +36,11 @@ export function editTree(plantContribution, plantId, navigation) { | |||
| dispatch(setProgressModelState(false)); | |||
| updateRoute('app_userHome', navigation || dispatch); | |||
| }) | |||
| .catch(error => { | |||
| debug(error.response); | |||
| .catch(response => { | |||
There was a problem hiding this comment.
A Promise must only reject with an Error. The only thing .catch can catch would be an Error.
putAuthenticatedRequest is .catching errors, handling that with onAPIError which then throws an Error. It does not throw a Response
|
See: axios/axios#960 (comment) It's axios that would throw the error. The error would have the response at error.response but ... the error was thrown by something else before axios even got called: |
|
I think I better discard this patch too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1210
Fix #1211
Fix #1003
I think this is the same duplication of trying to access a
responseobject as in 968a9fc - is it?