Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms and conditions -- Hyperlink and Content missing; Casing fix #305

Open
Preetha007 opened this issue Oct 27, 2021 · 12 comments
Open

Terms and conditions -- Hyperlink and Content missing; Casing fix #305

Preetha007 opened this issue Oct 27, 2021 · 12 comments
Assignees
Labels

Comments

@Preetha007
Copy link
Collaborator

In SignUp page, the content "terms and conditions" missing its Hyperlink and Content; Also Casing of "T" in terms and "C" in conditions could be changed to Caps.

Steps To Reproduce

  1. Go to https://test-app.nullcast.dev/curriculum
  2. Click on Login Button, where user redirected to the Login page.
  3. Click on Sign Up Button, where user gets displayed the Sign Up form.
  4. The Checkbox contents "terms and conditions" missing its Hyperlink and Content.
  5. Also Casing of "T" in terms and "C" in conditions could be changed to Caps.

Expected behavior
User when clicks on the "Terms and Conditions" hyperlink, have to redirect the user to the Terms and Conditions page. And the Casing of "T" in terms and "C" in conditions as Caps.

Recording attached*
https://www.loom.com/share/0ec0d7f35c97494ca283eaad99bb1f78

Desktop (please complete the following information): ThinkPad

  • OS: Linux
  • Browser: Linux
  • Version: Version 95.0.4638.54 (Official Build) (64-bit)

Smartphone: Not Tested

Additional context
Tested in Testsite

@Preetha007 Preetha007 added bug Something isn't working hacktoberfest labels Oct 27, 2021
@Preetha007 Preetha007 added this to the postgres-launch milestone Oct 27, 2021
@sk6298
Copy link
Contributor

sk6298 commented Oct 27, 2021

can I work on this ?

@thealpha93
Copy link
Member

yeah.. you can @sk6298

@thealpha93 thealpha93 added the good first issue Good for newcomers label Oct 27, 2021
@sk6298
Copy link
Contributor

sk6298 commented Oct 27, 2021

Can you share route for terms and condition page ? @thealpha93

@thealpha93
Copy link
Member

@sk6298 It's in the signup page
https://test-app.nullcast.dev/signup

Note: we don't have the content for terms and conditions yet

@sk6298
Copy link
Contributor

sk6298 commented Oct 27, 2021

@thealpha93 Sorry if I was not clear, I want to know where to redirect when user click on terms and conditions. Also can I make one pull request for #305 and #307 or should I keep them seprate ?

@thealpha93 thealpha93 added help wanted Extra attention is needed and removed good first issue Good for newcomers labels Oct 27, 2021
@thealpha93
Copy link
Member

@sk6298 We haven't created the terms and conditions page yet. So no need to redirect it now. So I'm going to label this issue as help wanted. We'll work on this issue after the terms and conditions page is created

@thealpha93
Copy link
Member

@sk6298 But you can work on #307

@thealpha93
Copy link
Member

@sk6298
Would you like to join our discord server and collaborate directly with us?

https://discord.gg/UNqCpTAU

@sk6298
Copy link
Contributor

sk6298 commented Oct 27, 2021

@thealpha93 will correct typo also in #307 then as well as css fix. Would love to join discord

sk6298 added a commit to sk6298/curriculum that referenced this issue Oct 27, 2021
@thealpha93
Copy link
Member

Cool. Here's the invite link: https://discord.gg/UNqCpTAU

@thealpha93 thealpha93 added needs investigation and removed help wanted Extra attention is needed labels Oct 27, 2021
@sk6298
Copy link
Contributor

sk6298 commented Oct 27, 2021

Corrected typo in this pull request:
#310

@thealpha93
Copy link
Member

Thanks @sk6298

@thealpha93 thealpha93 removed this from the postgres-launch milestone Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants