Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Nav bar menu closed on the Outside click of the page in the JS Curriculum page for a better UX #283

Closed
Preetha007 opened this issue Oct 26, 2021 · 4 comments · Fixed by #301
Assignees
Labels
bug Something isn't working hacktoberfest

Comments

@Preetha007
Copy link
Collaborator

Make the Nav bar menu closed on the Outside click of the page in the JS Curriculum page for a better UX.
A clear and concise description of what the bug is.

Steps to reproduce the behavior:

  1. Go to https://test-app.nullcast.dev/curriculum
  2. Click on School of Ducks.
  3. Scroll down to the Curriculum section.
  4. Click on the "Learn More" button of the Javascript course, where the user gets redirected inside the Javascript page.
  5. Scroll down and click on Start button.
  6. User could see the Hamburger icon on the bottom left, which when clicked opens the Navigation bar menu.
  7. Eventhough a Close button provided on the navigation menu, the user unable to close the view the Chapters on the Outside click, since the Nav bar menu not sliding inside.

Expected behavior
Make the Navigation bar menu closed on the Outside click of the page in the JS Curriculum page for a better UX

Desktop (please complete the following information): ThinkPad

  • OS: Linux
  • Browser: Google Chrome
  • Version -- Version 95.0.4638.54 (Official Build) (64-bit)

Smartphone (please complete the following information): Not tested in a smart phone.

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Tested in testsite

Recording attached
https://user-images.githubusercontent.com/92918179/138834824-c0cd6183-7335-48d2-aaa2-38d0920a53aa.mp4

@Preetha007 Preetha007 added bug Something isn't working hacktoberfest labels Oct 26, 2021
@Preetha007 Preetha007 added this to the postgres-launch milestone Oct 26, 2021
jasurobo pushed a commit to jasurobo/curriculum that referenced this issue Oct 26, 2021
navbar menu outside click added in curriculam page
jasurobo pushed a commit to jasurobo/curriculum that referenced this issue Oct 26, 2021
navbar menu outside click added in curriculam page
@christoph-codes
Copy link

@Preetha007 I can take this if you would like to assign this to me!

christoph-codes pushed a commit to christoph-codes/curriculum that referenced this issue Oct 26, 2021
Add empty clickable div underneath the sidebar to fire the toggle function that closes the sidebar.

fixes issue Planet-NULLCAST#283
@thealpha93
Copy link
Member

@christoph-codes Sure. Assigned to you. Thanks

@thealpha93 thealpha93 linked a pull request Oct 27, 2021 that will close this issue
10 tasks
christoph-codes pushed a commit to christoph-codes/curriculum that referenced this issue Oct 27, 2021
Add empty clickable div underneath the sidebar to fire the toggle function that closes the sidebar.

fixes issue Planet-NULLCAST#283
@thealpha93
Copy link
Member

Thanks. @christoph-codes Feel free to to browse around for more issues. Closing this issue

@christoph-codes
Copy link

@thealpha93 will do! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
4 participants