Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build/minify step #10

Closed
fluffy-critter opened this issue Dec 3, 2019 · 6 comments
Closed

Add build/minify step #10

fluffy-critter opened this issue Dec 3, 2019 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@fluffy-critter
Copy link
Collaborator

Following on from #9, if there's going to be npm packaging, might as well also add in a build/minification/test step.

@fluffy-critter fluffy-critter added the help wanted Extra attention is needed label Dec 3, 2019
@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Dec 4, 2019

Do you have preferred tooling?
Something like

  • Grunt
  • Gulp
  • Webpack
  • Parcel
  • Rollup

Or can we go plain npm run-scripts?
For JS minification, use terser. It's the successor of uglify-js.

I can fill a PR if you want.
Just need to know, whether you have prior experience with some of the tooling.

@fluffy-critter
Copy link
Collaborator Author

I'm pretty apathetic to the specific tooling, as I do not live in the JavaScript packaging universe, I just occasionally glance blows with it. Just keep it simple, y'know?

I mean I usually just use a Makefile for this sort of thing.

Ryuno-Ki added a commit to Ryuno-Ki/webmention.js that referenced this issue Dec 4, 2019
@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Dec 4, 2019

But you have „Web” in this org :o

Just kidding. Find JS part in #11.

fluffy-critter added a commit that referenced this issue Dec 4, 2019
@fluffy-critter
Copy link
Collaborator Author

Fixed in #11. Thanks!

@fluffy-critter
Copy link
Collaborator Author

But you have „Web” in this org :o

Didn't you hear? Server-side rendering is the future! Google invented it and everything. ;)

@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Dec 4, 2019

Google invented it and everything.

Oh, yeah! Let's rewrite everything in Angular :-D

Glad that I could help :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants