Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uth requests
Summary
Canonicizes identity URLs to make the netloc case-insensitive and path non-empty.
Supports
rel="canonical"
on TicketAuth grant requests. Fixes #486Detailed description
The users
http://example.com
,http://Example.com
, andhttp://example.com/
should all be equivalent.Also, since TicketAuth has no mechanism for the endpoint to provide its own canonical identity, the only way for TicketAuth to prove ownership of a canonical URL is for the profile to provide
rel="canonical"
and for the ticket granter to forward its request to that canonical URL. So this change will forward a TicketAuth grant request ifrel="canonical"
is provided, with no trust given to the forwarding page (to avoid the situation where for examplehttps://alice.example
provides a TicketAuth endpoint and also arel="canonical"
ofhttps://bob.example
).Developer/user impact
Test plan
Added appropriate unit tests.
Got a site to show off?