Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicize user identity URLs #487

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Conversation

fluffy-critter
Copy link
Collaborator

…uth requests

Summary

Canonicizes identity URLs to make the netloc case-insensitive and path non-empty.

Supports rel="canonical" on TicketAuth grant requests. Fixes #486

Detailed description

The users http://example.com, http://Example.com, and http://example.com/ should all be equivalent.

Also, since TicketAuth has no mechanism for the endpoint to provide its own canonical identity, the only way for TicketAuth to prove ownership of a canonical URL is for the profile to provide rel="canonical" and for the ticket granter to forward its request to that canonical URL. So this change will forward a TicketAuth grant request if rel="canonical" is provided, with no trust given to the forwarding page (to avoid the situation where for example https://alice.example provides a TicketAuth endpoint and also a rel="canonical" of https://bob.example).

Developer/user impact

Test plan

Added appropriate unit tests.

Got a site to show off?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TicketAuth should respect rel="canonical"
1 participant