Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zone): [PPT-1416] add timezone field to zone #34

feat(zone): [PPT-1416] add timezone field to zone

b13b97b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat(zone): [PPT-1416] add timezone field to zone #34

feat(zone): [PPT-1416] add timezone field to zone
b13b97b
Select commit
Loading
Failed to load commit list.
GitHub Actions / Ameba failed Jun 28, 2024 in 1s

Crystal Ameba Results

Total files checked: 75
Issues found: 19

Ameba Version: 1.4.3
Crystal Version: 1.7.0

Annotations

Check notice on line 9 in src/placeos/api/models/trigger_instance.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'enabled'
Raw output
> getter enabled : Bool = true
         ^

Check notice on line 10 in src/placeos/api/models/trigger_instance.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'triggered'
Raw output
> getter triggered : Bool = false
         ^

Check notice on line 11 in src/placeos/api/models/trigger_instance.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'important'
Raw output
> getter important : Bool = false
         ^

Check notice on line 12 in src/placeos/api/models/trigger_instance.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'exec_enabled'
Raw output
> getter exec_enabled : Bool = false
         ^

Check notice on line 50 in src/placeos/api/models/system.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'bookable'
Raw output
> getter bookable : Bool
         ^

Check notice on line 28 in src/placeos/api/models/driver.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'ignore_connected'
Raw output
> getter ignore_connected : Bool
         ^

Check notice on line 13 in src/placeos/api/models/oauth_application.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'skip_authorization'
Raw output
> getter skip_authorization : Bool
         ^

Check notice on line 14 in src/placeos/api/models/oauth_application.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'confidential'
Raw output
> getter confidential : Bool
         ^

Check notice on line 31 in src/placeos/api/models/module.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'makebreak'
Raw output
> getter makebreak : Bool
         ^

Check notice on line 48 in src/placeos/api/models/module.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'connected'
Raw output
> getter connected : Bool
         ^

Check notice on line 51 in src/placeos/api/models/module.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'running'
Raw output
> getter running : Bool
         ^

Check notice on line 54 in src/placeos/api/models/module.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'ignore_connected'
Raw output
> getter ignore_connected : Bool
         ^

Check notice on line 58 in src/placeos/api/models/module.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'ignore_startstop'
Raw output
> getter ignore_startstop : Bool
         ^

Check notice on line 6 in src/placeos/api/models/ping.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'pingable'
Raw output
> getter pingable : Bool
         ^

Check warning on line 40 in src/placeos/api_wrapper.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Lint/MissingBlockArgument

Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
Raw output
> def connection
      ^

Check warning on line 32 in src/placeos/client.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Lint/MissingBlockArgument

Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
Raw output
> def self.from_environment_user
           ^

Check notice on line 18 in src/placeos/api/models/asset_instance.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'approval'
Raw output
> getter approval : Bool
         ^

Check notice on line 14 in src/placeos/api/models/trigger.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'important'
Raw output
> getter important : Bool
         ^

Check notice on line 16 in src/placeos/api/models/trigger.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/QueryBoolMethods

Consider using 'getter?' for 'enable_webhook'
Raw output
> getter enable_webhook : Bool
         ^