Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable verbatimModuleSyntax #339

Merged
merged 11 commits into from
Jul 9, 2023
Merged

chore: enable verbatimModuleSyntax #339

merged 11 commits into from
Jul 9, 2023

Conversation

JaronZ
Copy link
Member

@JaronZ JaronZ commented Jun 30, 2023

No description provided.

@JaronZ JaronZ added Semver: Patch PRs that contain bugfixes and should be released in the next patch version. Meta: Refactor Issues and PRs related to refactors. Priority: Ultra-Low Issues and PRs with such a low priority it could be finished long after creation. Status: WIP Issues and PRs that are still a work in progress. labels Jun 30, 2023
@JaronZ JaronZ self-assigned this Jun 30, 2023
@mcpsbot mcpsbot added this to the New Update milestone Jun 30, 2023
@PixelPizza PixelPizza locked and limited conversation to collaborators Jul 1, 2023
mcpsbot
mcpsbot requested changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@mcpsbot mcpsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsolatedModules we need to change VerbatimModuleSyntax

@mcpsbot mcpsbot force-pushed the chore/enable-verbatimModuleSyntax branch from 3a4f1e5 to 92aa9a1 Compare July 7, 2023 17:41
@JaronZ
Copy link
Member Author

JaronZ commented Jul 7, 2023

IsolatedModules we need to change VerbatimModuleSyntax

It's still not compiling...

mcpsbot
mcpsbot previously approved these changes Jul 8, 2023
View reviewed changes
@JaronZ JaronZ marked this pull request as ready for review July 9, 2023 16:25
@JaronZ JaronZ requested a review from mcpsbot July 9, 2023 16:25
@mcpsbot
Copy link
Contributor

mcpsbot commented Jul 9, 2023

It came up with a problem

mcpsbot
mcpsbot previously approved these changes Jul 9, 2023
View reviewed changes
@JaronZ JaronZ requested a review from mcpsbot July 9, 2023 16:37
@JaronZ JaronZ enabled auto-merge July 9, 2023 16:37
@JaronZ JaronZ added this pull request to the merge queue Jul 9, 2023
Merged via the queue into main with commit 4764858 Jul 9, 2023
@JaronZ JaronZ deleted the chore/enable-verbatimModuleSyntax branch July 20, 2023 11:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcpsbot mcpsbot mcpsbot approved these changes

Assignees

@JaronZ JaronZ

Labels
Meta: Refactor Issues and PRs related to refactors. Priority: Ultra-Low Issues and PRs with such a low priority it could be finished long after creation. Semver: Patch PRs that contain bugfixes and should be released in the next patch version. Status: WIP Issues and PRs that are still a work in progress.
Projects
No open projects
OurTube
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaronZ @mcpsbot