Feature/PPPSYS-43233 server components support #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieltwork
approved these changes
Oct 13, 2023
mmalczewski
approved these changes
Oct 16, 2023
waszkowski
reviewed
Oct 16, 2023
| import {PageData} from '@/types/pageData' | ||
| import CustomDimensionResults from '@/src/components/CustomDimensions/CustomDimensionResults' | ||
| import Head from 'next/head' | ||
| import utilStyles from '../../styles/utils.module.css' |
There was a problem hiding this comment.
In example/app/CustomEvent/page.tsx file we have absolute import for CSS file, but here is a relative. Maybe we should keep one way to imports?
| return ( | ||
| <> | ||
| <Head> | ||
| <title>Piwik Pro - Nextjs 13 examples</title> |
There was a problem hiding this comment.
It's a small detail but should be "Piwik PRO" instead of "Piwik Pro" 😝
| const eCommerceExamples: FunctionComponent = () => { | ||
| const {eCommerce} = usePiwikPro() | ||
|
|
||
| const [eCommerceItems, setECommerceInfo] = useState<any>('') |
There was a problem hiding this comment.
There are two mismatch names "items" and "info" for the same state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all of the packages, must important: react, next, react-piwik-pro. Now able to use piwik pro in server components. Created new examples directory for next version >13
Task