Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window callbacks were previously behind a feature gate because the implementation i wrote was inherently unsafe. This was because the user could move the window object out of the
Box
after creating the window, and this would break the new callback code that requires the window pointer to never change. It just occurred to me to wrap theBox<Window>
inside a structPWindow
with its ownDeref
andDerefMut
implementations, preventing the user from taking the window out of the wrapper. This effectively stabilizes the new callback implementation so i removed the "glfw-callbacks" feature from Cargo.toml. Let me know if there is any problem, even tho i tested it and it seems to work.