Remove event::Raw in favour of using event::Input
#855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, conrod took `event::Raw` as the event type that drove forward the `Ui` and from which the `Ui` would generate higher-level `Event`s. It turns out we only ever really used the `event::Raw`'s `Input` variant, so to make our API more concise I thought we could remove the unnecessary indirection of `event::Raw`. One problem this does raise is that on Mac OS, we use the `event::Raw`'s `Render` variant as a hack to track the window's size changes. This is only because glutin (winit) is unable to emit events during resizing on Mac OS. To get around the removal of this hack, I'm planning to submit a PR to glutin_window (used by the piston backend present in most of the examples) which will insert `Resize` events manually. As a result of this change, we must also now pass the initial window dimensions to the `Ui`'s constructor. This commit also updates the related event module docs.
mitchmindtree
force-pushed
the
remove_raw_event
branch
from
ed1c191 to
2858310
Compare
|
Okydoke, the fix for |
This was referenced Nov 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the commit message:
Here is the PR that should fix the resize issues that appear on Mac OS when using the examples that depend on the piston feature: PistonDevelopers/glutin_window#99. Note that this is not related to the issue mentioned in #850 or #854.
Closes #820.