-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New project system & Cargo based build system #234
Conversation
The problem was System.Collections.Immutable 1.2.0
Copied from IntelliJ-Rust
They are still referenced from the VisualRust.Build project and copied to it's output directory.
This is a great change for the project and outweighs the loss of VS2013 support and with VS2015 Community freely available this shouldn't be much of a problem beyond migration. Great job to those involved. |
@vosen: It would be nice if you could comment what you think about this. Otherwise, if no one has any objections, I'm going to merge in a few days. |
Having both VisualRust and RTVS installed led to an MEF composition error (it still does, but loads anyway). I had previously tried to fix this by renaming IFileSystemMirroringProjectTemporaryItems, but that was not working. Removing the import of IProjectItemDependencyProvider (which we don't use) is the right fix.
Is visit_toml.dll and all Manifest stuff from Cargo project still needed? |
It's still included but currently unused. What's implemented in the PR is only reading the manifest using |
Added a DummyLogger implementation for the now required IActionLog parameter.
This is required to prevent MEF composition errors when RTVS is also loaded.
The idea of moving us to CPS is sound and is something that I wanted to do. |
The Good:
Cargo.toml
and callscargo build
internally).Cargo.toml
files and the solution explorer will show all the files in the respective directory (except for some filtered things, such as thetarget
folder). VS will still create a.rsproj
file, but it only contains some user settings.The Bad:
cargo build
output which includes dependencies can be reliably captured and parsed).rsproj
projects created with previous versions of VisualRust are completely incompatible with this new versionThe Rest: