Improvements for the "Talk to Self" feature #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most people will likely want to use Quick Travel a lot more than, say, Talk to Self, so it makes more sense.
The new icon is the original "Talk" icon but with a blue tint.
Changed the plain English string to a translatable one.
The following will stop the command from showing up: - Character is in fight mode - A boarding is in progress - Player alarm is active (character is in a fight) - The player is not currently controlling the character - The character is on Deck If the Character enters the deck with the "BI_EnterShip" interface command and then tries to talk to themself, the game crashes. That last condition is a temporary fix for this. I honestly have no idea why the crash occurs. I'm open to suggestions.
Hammie
approved these changes
Dec 28, 2024
|
Thanks! Sorry it took my this long to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Talk to Self on deck is now blocked. If the player entered the deck using the battle interface's EnterShip command, and then tried to use it, it crashed the game. It will require more testing to figure out why that happens.