Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items on a BlockGroup does not gets serialized on posts #577

Closed
stefanolsenn opened this issue Apr 9, 2019 · 5 comments
Closed

Items on a BlockGroup does not gets serialized on posts #577

stefanolsenn opened this issue Apr 9, 2019 · 5 comments
Assignees
Milestone

Comments

@stefanolsenn
Copy link

Hi @tidyui

So I upgraded to 6.0.2 in the EF package as you suggested, and checked that all the other packages are up to date, and tried again. And it works, yah! But only on a standardpage or a startpage.

It saves the actual blockgroup in the db, but not the children of the blockgroup. So the results are as it were the first time; an empty array when it gets serialized.

The code is same as in issue #543

@tidyui
Copy link
Member

tidyui commented Apr 9, 2019

Thanks for your feedback! Some errors seem to have snuck into the code when it was refactored during the 6.0 development. We’ll take a look and compare the Page & Post Services.

Regards

@stefanolsenn
Copy link
Author

All good! Thanks for your work, and the quick feedback. It's much appreciated!

@stefanolsenn
Copy link
Author

Hi @tidyui Any update on this, or any particular way you would recommend as a temporary solution?

@w0ns88
Copy link

w0ns88 commented Apr 26, 2019

Hi @tidyui it would be great to have the BlockGroup working for version 6.1. Would this be possible to be check soonish at all?

Regards

@tidyui tidyui added this to the Version 6.1 milestone Apr 26, 2019
@tidyui tidyui closed this as completed in 3a40344 Apr 26, 2019
@tidyui
Copy link
Member

tidyui commented Apr 26, 2019

This has now been fixed in master and will be deployed in 6.1

@tidyui tidyui self-assigned this Apr 26, 2019
@tidyui tidyui changed the title Items on a BlockGroup does not gets serialized on posts, but works on pages Items on a BlockGroup does not gets serialized on posts May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants