Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag and Category Services and Repos missing in 6.0 #556

Closed
w0ns88 opened this issue Apr 2, 2019 · 1 comment
Closed

Tag and Category Services and Repos missing in 6.0 #556

w0ns88 opened this issue Apr 2, 2019 · 1 comment
Labels

Comments

@w0ns88
Copy link

w0ns88 commented Apr 2, 2019

I am now upgrading to 6.0 and have noticed that the CaregoryService, CategoryRepository, TagService and TagRepository are missing.

I have had a look at the changelog and it seems they were deleted (by mistake?). The code can be found in PR #529 in the core/Piranha/Api.cs.

@tidyui tidyui added the question label Apr 2, 2019
@tidyui
Copy link
Member

tidyui commented Apr 2, 2019

Hi there.. No they are not missing, I will add a notice of them in the Changlog. As tags and categories does not exist outside of the Post archive their methods have been moved into the PostService. If the normalized SQL-repositories would be replaced with a NoSql-database this would be the logical place to have them as the repository methods would most likely just get all of the available tags in the posts in the specified archive.

The methods can be found here:

api.Posts.GetAllCategoriesAsync
api.Posts.GetCategoryBySlugAsync
api.Posts.GetAllTagsAsync
api.Posts.GetTagBySlugAsync

Best regards

@tidyui tidyui closed this as completed Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants