-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default support for most common media formats. #1359
Comments
The reason we support the specified formats is that need to consider which formats are supported by https://docs.sixlabors.com/articles/imagesharp/imageformats.html It appears by the documentation that they now supports |
Thanks for a quick reply: I threw together a quick method to get all supported formats:
jfif, jpeg and jpg are all the same. If you look at the header of a jpg/jpeg/jfif file you will see JFIF. As for .webp - yeah, it seems ImageSharp does not support it yet. As for .gif - it also works fine with resizing (although coloring in this example seems to be a bit off - could probably be corrected):
|
Hey! Imagesharp supports webp now :) Reopen? |
@magnuskarlssonhm I think perhaps we should open a new issue for .webp support as this issue was released in 9.1 |
According to the docs - https://piranhacms.org/docs/content/media
The following are supported by default but perhaps it is time to include .gif, .webp and .jfif as common formats too (by default):
#237
We can do this:
Piranha.App.MediaTypes.Images.Add(".gif", "image/gif");
Piranha.App.MediaTypes.Images.Add(".jfif", "image/jpeg");
...
https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Image_types
The text was updated successfully, but these errors were encountered: