Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route update in manager for .NET 5 #1324

Closed
Paw261 opened this issue Sep 2, 2020 · 8 comments
Closed

Route update in manager for .NET 5 #1324

Paw261 opened this issue Sep 2, 2020 · 8 comments

Comments

@Paw261
Copy link

Paw261 commented Sep 2, 2020

image

I am having a bit of trouble getting piranha up and running. Im using Piranha 8.4.2, in a .net core 3.1 application.

Im hoping you can help

@tidyui
Copy link
Member

tidyui commented Sep 2, 2020

Hi there. Can you specify exactly what runtime of .NET Core you are using as we can't reproduce this issue!

@Paw261
Copy link
Author

Paw261 commented Sep 2, 2020

I am using .NET Core 3.1.6

@tidyui
Copy link
Member

tidyui commented Sep 2, 2020

I will start by updating to the latest version 3.1.7 as I'm running 3.1.4

@tidyui
Copy link
Member

tidyui commented Sep 2, 2020

Sorry I mistook the numbers. I'm testing with sdk 3.1.401 which uses runtime 3.1.7 without issues. Can you give me some further specs about your setup, i.e operating system and stuff like that!

@Paw261
Copy link
Author

Paw261 commented Sep 2, 2020

Windows 10 Home edition

We are trying to intergrate Piranha into an existing project.

Here is what I have done in the Startup file.

ConfigureServices:
image

Configure:
image

I have tried using a custom login, so it is compatible with the existing system, by using the ISecurity interface

Hope this helps

@tidyui
Copy link
Member

tidyui commented Sep 3, 2020

Still can't recreate this on my side. The reason I asked for which runtime you were using is since the error messages say that the route can't contain a parameter named action, most likely because it thinks this is reserved by the system. This however is not an error message that we have ever encountered before, so if you had been running the application on a beta of .NET 5 it could've made sense that you got an error because they had changed something.

@tidyui
Copy link
Member

tidyui commented Sep 20, 2020

My guess is that the MVC route config for the rest of your application isn’t working with the manager as it seems that the keyword action has been reserved by asp.net core.

The simple solution would be for us to just rename the parameter for these pages.

@tidyui tidyui added this to the Version 9.0 milestone Sep 20, 2020
@tidyui
Copy link
Member

tidyui commented Dec 15, 2020

After upgrading master to .NET 5 we still can't recreate this issue, nevertheless we will change the name of the parameter to page edit and post edit to rule out the possibility of naming conflicts.

@tidyui tidyui closed this as completed in 10dabad Dec 15, 2020
@tidyui tidyui self-assigned this Jan 19, 2021
@tidyui tidyui changed the title RouteCreationException Route update in manager for .NET 5 Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants