Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module icons causes mixed content errors. #1304

Closed
mikaellindemann opened this issue Aug 15, 2020 · 0 comments · Fixed by #1305
Closed

Module icons causes mixed content errors. #1304

mikaellindemann opened this issue Aug 15, 2020 · 0 comments · Fixed by #1305
Assignees
Milestone

Comments

@mikaellindemann
Copy link
Contributor

All official Piranha modules uses the twitter-shield as module icon: http://piranhacms.org/assets/twitter-shield.png.

Since the URL for the twitter shield icon is specified using HTTP, Chrome (and potentially other browsers) complain that the manager interface is insecure because not all resources are served over HTTPS.

It seems that the Piranha website is able to serve the twitter shield over HTTPS: https://piranhacms.org/assets/twitter-shield.png.

I will submit a PR shortly, that changes all module icons to the HTTPS version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants