Merge pull request envoyproxy#98 from duderino/jblatt_moar_wasm_tests

Add test case for sendLocalResponse
PiotrSikora · Aug 16, 2019 · 0d1a0d4 · 0d1a0d4
2 parents 36e3280 + 8f60be9
commit 0d1a0d4
Show file tree

Hide file tree

Showing 4 changed files with 30,530 additions and 28,168 deletions.
diff --git a/test/extensions/filters/http/wasm/test_data/grpc_callout_cpp.cc b/test/extensions/filters/http/wasm/test_data/grpc_callout_cpp.cc
@@ -52,16 +52,16 @@ class CalloutResponseHandler : public GrpcCallHandler<google::protobuf::Value> {
 
     continueRequest();
   }
+
   void onFailure(GrpcStatus status,
                  std::unique_ptr<WasmData> error_message) override {
     request_context_->setEffectiveContext();
     logInfo(std::string("failure ") + std::to_string(static_cast<int>(status)) +
-            std::string(error_message->view()));
+            " " + std::string(error_message->view()));
 
     service_context_->incrementCalloutFailures();
 
-    // TODO wasm engine must support fail closed: expose abortRequest() or similar
-    continueRequest();
+    sendLocalResponse(502, error_message->view(), "", {}, status);
   }
 
  private:

diff --git a/test/extensions/filters/http/wasm/test_data/grpc_callout_cpp.wasm b/test/extensions/filters/http/wasm/test_data/grpc_callout_cpp.wasm