Fix bytecode for Python 3.12 #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@felixonmars you can enable github ci in your source repository and see how is tests going |
It seems all failing tests are because of unsupported old Python versions. |
|
yes look like tests passed |
worstperson
reviewed
May 6, 2024
3 tasks
`LOAD_ATTR` has been changed in Python 3.12 and it seems reusing the `LOAD_GLOBAL` logic makes the simple tests passing. I am not sure if this is correct since I'm pretty new to the code, but maybe it's still helpful.
|
I've tested it in my project, and it works as expected. @PiotrDabkowski, is there anything we can do to release it? |
Jamim
referenced
this pull request
in gentoo/gentoo
Jun 25, 2024
Signed-off-by: Maciej Barć <[email protected]>
|
man man man let's just fork it |
|
Also works in my project and fixed #317. Can this be approved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOAD_ATTRhas been changed in Python 3.12 and it seems reusing theLOAD_GLOBALlogic makes the simple tests passing.I am not sure if this is correct since I'm pretty new to the code, but maybe it's still helpful.
Fixes #317