Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/_crds/prow): apply prow crd from ti-community-infra/prow repo #1400

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Jan 3, 2025

with release branch.

@ti-chi-bot ti-chi-bot bot requested a review from purelind January 3, 2025 11:53
@ti-chi-bot ti-chi-bot bot added the area/apps label Jan 3, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the provided information, it seems that the pull request is fixing an issue related to the use of the Prow CRD in the ti-community-infra/prow repository. The diff shows that the change is simply replacing the URL for the Prow CRD resource in the kustomization.yaml file with the correct one from the ti-community-infra/prow repository.

There don't seem to be any potential problems with this pull request, as it appears to be a straightforward fix.

As for fixing suggestions, it would be good to test the changes locally to ensure that they work as expected before merging the pull request. Additionally, it might be helpful to add a more detailed description of the problem that this pull request is addressing, as well as any steps taken to verify that the fix works properly. This could be useful for other contributors who may encounter similar issues in the future.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Jan 3, 2025

/approve

Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 81ac5c8 into main Jan 3, 2025
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/update-prow-crd branch January 3, 2025 11:58
wuhuizuo added a commit that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant