Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps/prod): bump publisher version to v2024.12.12-6-g069f4f2 #1396

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo [email protected]

Copy link
Contributor

ti-chi-bot bot commented Dec 30, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

The pull request is a chore to bump the publisher version to v2024.12.12-6-g069f4f2 in the production environment. It includes changes to the following files:

  • apps/prod/publisher/release-prod-mirror.yaml
  • apps/prod/publisher/release-staging-mirror.yaml
  • apps/prod/tekton/configs/tasks/publish-fileserver-from-oci-artifact.yaml
  • apps/prod/tekton/configs/tasks/publish-tiup-from-oci-artifact-v2.yaml
  • apps/prod/tekton/configs/tasks/release/pingcap-create-github-alpha-tags.yaml

There are no potential problems with the pull request. However, it is always good to ensure that the new publisher version does not have any compatibility issues with the existing system.

As a fixing suggestion, it is a good practice to include some information about the changes made in the pull request description. It helps other developers to understand the reason for the changes made.

@ti-chi-bot ti-chi-bot bot requested a review from purelind December 30, 2024 09:11
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Dec 30, 2024
Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit afee218 into main Dec 30, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/bump-publisher-version branch December 30, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant