Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs/tasks/release): add ref issue for tikv bump task #1392

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind December 26, 2024 09:50
@ti-chi-bot ti-chi-bot bot added the area/apps label Dec 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 26, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request description and diff, the key change is the addition of an environment variable REF_ISSUE_NUMBER with the value of 456 in the create-pr-to-bump-tikv-version.yaml file.

One potential problem is that there is no explanation of why this environment variable is needed and how it will be used. Also, the pr_body.txt file that is created in the script seems to reference this variable, but it is not clear how it will be populated.

To fix this, the pull request submitter should provide a clear explanation of the purpose of the REF_ISSUE_NUMBER environment variable and how it will be used in the create-pr-to-bump-tikv-version.yaml file and the pr_body.txt file. Additionally, they should consider adding a comment in the script to explain how the variable will be populated.

@ti-chi-bot ti-chi-bot bot added env/prod will deploy on the main product cluster size/S labels Dec 26, 2024
Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit c83918b into main Dec 26, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/add-ref-issue-for-tikv-bump-task branch December 26, 2024 09:53
wuhuizuo added a commit that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant