Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/prod/tekton/configs/tasks/release): add task pingcap-create-github-alpha-tags #1391

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

wuhuizuo
Copy link
Collaborator

The script will be implemented in the future.

Signed-off-by: wuhuizuo [email protected]

…-github-alpha-tags

The script will be implemented in the future.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from purelind December 24, 2024 09:28
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Dec 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 24, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, the changes being made is the addition of a new task called pingcap-create-github-alpha-tags. This task creates GitHub alpha tags on product GitHub repositories and sends GitHub push events to trigger a build with new git metadata. The task is written in Deno and requires a token to be provided in the github workspace.

From the diff provided, the changes look good and follow the established pattern for adding new tasks. However, there are a few potential problems that I can see:

  1. The script is not yet implemented, and the PR description does not provide any additional information on when it will be implemented. It would be helpful to have a timeline on when this will be completed.
  2. The pushEventUrl parameter seems to be hardcoded to http://el-public:8080. This may not be a problem depending on the environment, but it would be better to make this parameter configurable or use an environment variable.

To address the first potential problem, I suggest asking the author for more information on when the script will be implemented and ensuring that there is a clear timeline. For the second potential problem, I suggest making the pushEventUrl parameter configurable or using an environment variable to ensure that it can be easily changed if needed.

Overall, the changes look good, and I recommend approving the PR once the potential problems are addressed.

@ti-chi-bot ti-chi-bot bot added the size/S label Dec 24, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 24, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1cbd986 into main Dec 24, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/add-alpha-tag-task branch December 24, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant