Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Pineapple to Paper API #59

Merged
merged 24 commits into from
Feb 6, 2025
Merged

Convert Pineapple to Paper API #59

merged 24 commits into from
Feb 6, 2025

Conversation

The-Epic
Copy link
Member

@The-Epic The-Epic commented Jan 29, 2025

This PR aims to convert all spigot api usage and nms to paper and its api. This PR also introduces the ability for kotlin to be used internally and allows for kotlin apis to be created, plus a kotlin extension api is provded for the core module. Reverts the bundle'd core design back to a published parent + modules where the parent transitive depends on the common modules every plugin would require to make pineapple work and use it to its best ability. NMS is fully removed except for api, ideally NMS shouldnt be needed but in the short term before a pr is created and merged the api exists for when its needed.

TODO

  • Finish build files
  • Fix deprecated code usage
  • Add api dir + port tiles and infstack to it
  • Kotlin extension/api module
  • Convert to use Spotless Gradle for checkstyling
  • Convert pineapple chat to adventure
  • Test all modified features in a plugin on a server (tested in collect)

@The-Epic The-Epic marked this pull request as draft January 29, 2025 21:24
Copy link
Member

@Y2Kwastaken Y2Kwastaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

@The-Epic The-Epic requested a review from Y2Kwastaken January 30, 2025 17:37
@The-Epic The-Epic marked this pull request as ready for review January 30, 2025 22:44
Copy link
Member

@Y2Kwastaken Y2Kwastaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly, just a few things. Only other thing I'd recommend changing is the bukkit command stuff over to the brig backed "BasicCommand" its a small change, but egh I prefer to be atleast backed by the new API the existence of me makes me think the command executors could be chopped, which would be kinda dumb, but whatever. If you don't feel like it I'll just port it later if I ever get the energy.

@Y2Kwastaken Y2Kwastaken self-requested a review February 1, 2025 02:56
@The-Epic The-Epic merged commit 1cb3642 into dev Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants