-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Pineapple to Paper API #59
Conversation
# Conflicts: # settings.gradle.kts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far
...e-core/src/main/java/sh/miles/pineapple/util/serialization/adapter/spec/ItemSpecAdapter.java
Outdated
Show resolved
Hide resolved
...e-core/src/main/java/sh/miles/pineapple/util/serialization/adapter/spec/ItemSpecAdapter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good mostly, just a few things. Only other thing I'd recommend changing is the bukkit command stuff over to the brig backed "BasicCommand" its a small change, but egh I prefer to be atleast backed by the new API the existence of me makes me think the command executors could be chopped, which would be kinda dumb, but whatever. If you don't feel like it I'll just port it later if I ever get the energy.
This PR aims to convert all spigot api usage and nms to paper and its api. This PR also introduces the ability for kotlin to be used internally and allows for kotlin apis to be created, plus a kotlin extension api is provded for the core module. Reverts the bundle'd core design back to a published parent + modules where the parent transitive depends on the common modules every plugin would require to make pineapple work and use it to its best ability. NMS is fully removed except for api, ideally NMS shouldnt be needed but in the short term before a pr is created and merged the api exists for when its needed.
TODO