✨ Adding message history

[Sigmanificient]

c = await self.get_channel(...)

async for m in c.history(limit=1000):
    # To your stuff

[codecov]

Codecov Report

Merging #380 (83f1d02) into main (9db7e1b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files           8        8           
  Lines          74       74           
=======================================
  Hits           67       67           
  Misses          7        7           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db7e1b...83f1d02. Read the comment docs.

[Lunarmagpie]

limit HAS to be capped to 100. If they choose a number too big there will be rate limits and that will cause it to stall because of an "invisible error"

[Sigmanificient]

I don't agree, we need to provide an user-friendly way to get all messages within a channel, even if it is extremely slow.
Discord.py do it has well, see channel.history(limit=...).flatten()

Also it deal very nicely with ratelimiting.
I test it with 4000 messages, in 41.18647676300316 seconds
For 8000 messages, it took 84.87266815700423 seconds

[Lunarmagpie]

I see your point but you need to change things
There can be a lot of api calls so you should use gather. You can even use itertools.chain around gather. I bet that would be useful here.

[Lunarmagpie]

I see your point but you need to change things
There can be a lot of api calls so you should use gather. You can even use itertools.chain around gather. I bet that would be useful here.

[Lunarmagpie]

Sorry on mobile

before = raw_messages[-1].id
for message in raw_messages:
    yield UserMessage.from_dict(message)

[Sigmanificient]

raw_messages is not yet converted payload, so you cant access .id, i guess we can do ["id"] tho

[Lunarmagpie]

I think that would be bettr