This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
✨ Implements Ratelimiter to prevent 429s from user scope
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 9 9
Lines 100 100
=======================================
Hits 90 90
Misses 10 10 Continue to review full report at Codecov.
|
Lunarmagpie
changed the title
user requestsuser scope
trag1c
approved these changes
Nov 29, 2021
Co-authored-by: trag1c <[email protected]>
VincentRPS
suggested changes
Nov 30, 2021
Enderchief
approved these changes
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
adds: RATE LIMITINGUser scope is prevented by the ratelimiter. The shared scope is impossible to prevent according to some dude from the discord API server so I can ignore that one. I did not implement a way to prevent global rate limits in this PR.
All logging is under Info scope. Someone say something if you think it should be under a different one.
Check off the following