Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Angular 5.0 compatibility #72

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Conversation

ryzy
Copy link
Contributor

@ryzy ryzy commented Nov 2, 2017

Makes it compatible with Angular 5. Tested, works in ng5 app and will continue to work on ng4.

OpaqueToken was deprecated with v4 and has been completely removed in v5.

If you ok with it, I'll send a sync of ./dist dir.

Thanks, cheers!

@ryzy
Copy link
Contributor Author

ryzy commented Nov 2, 2017

Also, if you willing to switch to angular-cli for dev, I could update whole project to use Angular 5 (i.e. the example app).

@ryzy
Copy link
Contributor Author

ryzy commented Nov 2, 2017

Hey @PillowPillow,

I see there's already another PR there with the same. I get you must be busy, but, this one is easy to merge (two lines change + dist) and we're on Angular 5.

@ryzy
Copy link
Contributor Author

ryzy commented Nov 2, 2017

PS. If you're looking for help with maintaining this one, happy to help - working full time with Angular, using your package in my company, we like it, so can help at least with minimal maintenance and responding to PRs.

@aurimukas
Copy link

Agree with @ryzy we should know, if this module is not maintained any more.. we should get someone who checks it more often or do a fork..

@svitlychnyi
Copy link

+1

@civicwar
Copy link

civicwar commented Nov 3, 2017

@ryzy
careful with those false positive changes like:

  • Indentation ( TAB , SPACE )
  • CRLF / LF
  • EOF

because i see many changed files with false positives.

@RasmusTG
Copy link

RasmusTG commented Nov 5, 2017

+1

@nblavoie
Copy link

nblavoie commented Nov 6, 2017

@PillowPillow We need this ASAP. Thanks.

@Gillardo
Copy link

Gillardo commented Nov 6, 2017

@PillowPillow ?? Can you merge please?

@mbenzenhoefer
Copy link

+1

1 similar comment
@tommueller
Copy link

+1

@Hopchenko Hopchenko mentioned this pull request Nov 7, 2017
@stas-kh
Copy link

stas-kh commented Nov 7, 2017

+1

@nblavoie
Copy link

nblavoie commented Nov 7, 2017

Can we simply fork the project with the included fixes?

@svitlychnyi
Copy link

Author is, most probably, just has no time at the moment, but he is active:
Contribution activity: November 7, 2017 (32 contributions in private repositories)

Lets just wait for some time.

@Gillardo
Copy link

Gillardo commented Nov 7, 2017

I am just using branch by @ryzy . works perfectly!

@PillowPillow PillowPillow merged commit 449d8cf into PillowPillow:master Nov 7, 2017
@svitlychnyi
Copy link

Aha, I told you :)

@svitlychnyi svitlychnyi mentioned this pull request Nov 7, 2017
@Gillardo
Copy link

Gillardo commented Nov 7, 2017

can you tell us when this will be updated on npm please?

@nblavoie
Copy link

nblavoie commented Nov 7, 2017

@Gillardo +1 !

@atigm
Copy link

atigm commented Nov 7, 2017

While waiting for tag, you can use the master code :
npm install git://github.com/PillowPillow/ng2-webstorage --save
It's working for me

@PillowPillow
Copy link
Owner

During the night, it will comes with some bug fixes.

@ryzy
Copy link
Contributor Author

ryzy commented Nov 12, 2017

@PillowPillow thanks for merging and a new release, great job!

BTW @civicwar agree, the only reason why there were changes in this is because the repo contains also compiled dist version of the package and it's the result of whatever ngc compiler produces. My change was in one line only :D @PillowPillow might decide at some point to change it (e.g. prepare the dist just for npm publish and exclude it from the source code of the repository).

@PillowPillow
Copy link
Owner

PillowPillow commented Nov 12, 2017

I'm keeping the dist in the repo for those who prefers use bower.
Since i'm not maintaining a bower repo, they can take the sources from github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet