-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Angular 5.0 compatibility #72
Conversation
Also, if you willing to switch to |
Hey @PillowPillow, I see there's already another PR there with the same. I get you must be busy, but, this one is easy to merge (two lines change + dist) and we're on Angular 5. |
PS. If you're looking for help with maintaining this one, happy to help - working full time with Angular, using your package in my company, we like it, so can help at least with minimal maintenance and responding to PRs. |
Agree with @ryzy we should know, if this module is not maintained any more.. we should get someone who checks it more often or do a fork.. |
+1 |
@ryzy
because i see many changed files with false positives. |
+1 |
@PillowPillow We need this ASAP. Thanks. |
@PillowPillow ?? Can you merge please? |
+1 |
1 similar comment
+1 |
+1 |
Can we simply fork the project with the included fixes? |
Author is, most probably, just has no time at the moment, but he is active: Lets just wait for some time. |
I am just using branch by @ryzy . works perfectly! |
Aha, I told you :) |
can you tell us when this will be updated on npm please? |
@Gillardo +1 ! |
While waiting for tag, you can use the master code : |
During the night, it will comes with some bug fixes. |
@PillowPillow thanks for merging and a new release, great job! BTW @civicwar agree, the only reason why there were changes in this is because the repo contains also compiled |
I'm keeping the dist in the repo for those who prefers use bower. |
Makes it compatible with Angular 5. Tested, works in ng5 app and will continue to work on ng4.
OpaqueToken
was deprecated with v4 and has been completely removed in v5.If you ok with it, I'll send a sync of
./dist
dir.Thanks, cheers!