Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew bump: add prerelease exception #14

Closed
wants to merge 6 commits into from

Conversation

toobuntu
Copy link
Contributor

Ugh. Please delete the release and trigger the build again.

@PikachuEXE
Copy link
Owner

Thanks but I did it already :P
96fcbd8

@toobuntu
Copy link
Contributor Author

Strange, though, that the action still uses a workflow file with the v--and fails--even after your commit to master.

The good news is that it is being triggered.

@PikachuEXE
Copy link
Owner

Maybe use this PR to fix new error I mentioned in
#13 (comment)

@toobuntu toobuntu force-pushed the actions/tap-update branch from a45f700 to 8ebf862 Compare March 25, 2024 02:05
@toobuntu
Copy link
Contributor Author

Maybe use this PR to fix new error I mentioned in #13 (comment)

Okay. Let's see if this does it.

@toobuntu toobuntu changed the title fix: action reference fix: token permissions Mar 25, 2024
@PikachuEXE
Copy link
Owner

Oops I did it again - -|||
#13 (comment)

Anyway still fail maybe it needs extra permission?
Checking

@PikachuEXE
Copy link
Owner

PikachuEXE commented Mar 25, 2024

It's getting user info in https://github.com/eugenesvk/action-homebrew-bump-cask/blob/master/main.rb#L70

My guess is that specifying permissions removes some default permissions so it can't read user info

Update 1: Nope can't find permission needed for reading /user in https://docs.github.com/en/rest/authentication/permissions-required-for-github-apps?apiVersion=2022-11-28

@toobuntu toobuntu changed the title fix: token permissions brew bump: add prerelease exception Mar 27, 2024
@toobuntu toobuntu force-pushed the actions/tap-update branch from 0376a05 to 3110f8c Compare March 27, 2024 01:55
@toobuntu toobuntu closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants