Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React v2.0.2 patch #337

Merged
merged 4 commits into from
Nov 30, 2023
Merged

React v2.0.2 patch #337

merged 4 commits into from
Nov 30, 2023

Conversation

albho
Copy link
Contributor

@albho albho commented Nov 30, 2023

No description provided.

@albho albho requested a review from laves November 30, 2023 21:10
@albho
Copy link
Contributor Author

albho commented Nov 30, 2023

If stopRecording is called inside the interval, the !isRecording check will always be true since the value of isRecording doesn't get updated inside the interval.

laves
laves approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@laves laves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool - go ahead and release

@laves laves merged commit 55af0bc into master Nov 30, 2023
8 checks passed
@laves laves deleted the react-v2.0.2-patch branch November 30, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laves laves laves approved these changes

Assignees

@laves laves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albho @laves