Sync Checkstyle integration test

[Stephan202]

The two commits are independently reviewable.

Suggested commit message:

Sync Checkstyle integration test (#999)

Summary of changes:
- Update the set of expected changes for compatibility with the latest
  features, except for the `ErrorProneRuntimeClasspath` check.
- Test against version 10.12.7 rather than 10.13.0.
- Omit the targeted tag from file names, so that similar upgrade PRs can be
  tested using an `/integration-test` GitHub comment.

[Stephan202]

/integration-test

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[Stephan202]

/integration-test

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[Stephan202]

The /integration-test build fails, because (IIUC) the GitHub action config is derived from master. Perhaps we should rename the scripts to omit the exact tag used. Assuming we don't want to track multiple tags per project, this will simplify things.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[Stephan202]

Added a commit and updated the suggested commit message. Do still need to validate these changes locally.

[rickie]

Cool stuff! At least locally it now runs for me 😄. Already updated #867 with the latest state of this PR.

[Stephan202]

I noticed that with my changes at some point the build would fail with:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.12.1:compile (error-prone-compile) on project checkstyle: Fatal error compiling: AmbiguousJsonCreator is not a valid checker name -> [Help 1]

I added a commit to fix that.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[Stephan202]

K, validated the latest changes. PR is now properly ready for review.

[Stephan202]

Rebased and updated the PR to target version 10.13.0. Suggested commit message updated.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[rickie]

Thanks for bringing this one up-to-date!

Smart move to drop the version from the file names :).

Ran it locally and it works :).

[mohamedsamehsalah]

Is the goal here to run /integration-tests/checkstyle.sh succesfully ?
Because It is not running for me (macOs).

usage: paste [-s] [-d delimiters] file ...
grep: invalid option -- P
usage: grep [-abcdDEFGHhIiJLlMmnOopqRSsUVvwXxZz] [-A num] [-B num] [-C[num]]
        [-e pattern] [-f file] [--binary-files=value] [--color=when]
        [--context[=num]] [--directories=action] [--label] [--line-buffered]
        [--null] [pattern] [file ...]

also fails with --sync flag. What am I missing ?

[rickie]

We're working on that in #867 😄. Although I myself get some changes on that branch... So Mac support is close I'm working on it.

[mohamedsamehsalah]

Clear 👍

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[rickie]

Rebased,will merge!

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud