Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow static imports of ZERO and ONE identifiers #996

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

rickie
Copy link
Member

@rickie rickie commented Jan 26, 2024

We think that in the contexts where this happen it usually does make sense to statically import these identifiers.

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 🔢

@Stephan202 Stephan202 added this to the 0.15.0 milestone Jan 28, 2024
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested commit message:

Allow static imports of `ZERO` and `ONE` identifiers (#996)

@rickie rickie force-pushed the rossendrijver/zero_one branch from 5e62bef to 8596e88 Compare January 28, 2024 18:11
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rickie rickie merged commit a926e55 into master Jan 28, 2024
16 checks passed
@rickie rickie deleted the rossendrijver/zero_one branch January 28, 2024 18:32
@Stephan202 Stephan202 changed the title Allow static imports of {ZERO,ONE} identifiers Allow static imports of ZERO and ONE identifiers Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants