Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce InputStream{Read,Skip}NBytes Refaster rules #993

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Introduce InputStream{Read,Skip}NBytes Refaster rules #993

merged 1 commit into from
Feb 13, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Jan 25, 2024 •
edited
Loading

❗ This PR is on top of #603 ❗

Suggested commit message:

Introduce `InputStream{Read,Skip}NBytes` Refaster rules (#993)

@Stephan202 Stephan202 added this to the 0.16.0 milestone Jan 25, 2024
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

mohamedsamehsalah
mohamedsamehsalah approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good bye JDK 11 👋

image

Venorcis
Venorcis approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@Venorcis Venorcis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Stephan202 Stephan202 force-pushed the sschroevers/require-jdk-17 branch from 7fdbd0d to 6ed8caf Compare February 11, 2024 15:45
Base automatically changed from sschroevers/require-jdk-17 to master February 11, 2024 15:57
@Stephan202 Stephan202 force-pushed the sschroevers/add-inputstream-refaster-rules branch from 95cd5f2 to 27d2dec Compare February 11, 2024 15:58
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the sschroevers/add-inputstream-refaster-rules branch from 27d2dec to 953f2b3 Compare February 13, 2024 08:14
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rickie rickie merged commit c2365c0 into master Feb 13, 2024
15 checks passed
@rickie rickie deleted the sschroevers/add-inputstream-refaster-rules branch February 13, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@rickie rickie rickie approved these changes

@Venorcis Venorcis Venorcis approved these changes

Assignees
No one assigned
Labels
new feature
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Stephan202 @Venorcis @rickie @mohamedsamehsalah