Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid NPE in IsEmpty matcher #978

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Jan 16, 2024

Suggested commit message:

Avoid NPE in `IsEmpty` matcher (#978)

(This issue was flagged by both Checker Framework and Qodana, which I'm evaluating on other branches.)

@Stephan202 Stephan202 added this to the 0.15.0 milestone Jan 16, 2024
" return new Random();",
" }",
"",
" List<Integer> negative6() {",
" List<Integer> negative7() {",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this renaming is a mess. But proposing an alternative is not on today's menu.

Copy link

Looks good. All 2 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.refaster.matchers.IsEmpty 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rickie rickie force-pushed the sschroevers/avoid-isempty-npe branch from 9d777f0 to 3f5867a Compare January 20, 2024 11:26
Copy link

Looks good. All 2 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.refaster.matchers.IsEmpty 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

@rickie rickie added the bug fix label Jan 20, 2024
@rickie rickie merged commit dc65917 into master Jan 20, 2024
16 checks passed
@rickie rickie deleted the sschroevers/avoid-isempty-npe branch January 20, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants