Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop workaround for resolved Refaster bug #974

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Drop workaround for resolved Refaster bug #974

merged 1 commit into from
Jan 13, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Jan 13, 2024 •
edited
Loading

Suggested commit message:

Drop workaround for resolved Refaster bug (#974)

Issue google/error-prone#2456 was fixed in Error Prone 2.22.0.

@Stephan202 Stephan202 added this to the 0.15.0 milestone Jan 13, 2024
mohamedsamehsalah
mohamedsamehsalah approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two XXX's in one PR 🔥

@github-actions GitHub Actions
Copy link

Looks good. All 1 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.refaster.runner.Refaster 0 1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rickie rickie merged commit d126336 into master Jan 13, 2024
16 checks passed
@rickie rickie deleted the sschroevers/drop-obsolete-workaround branch January 13, 2024 19:43
@Stephan202 Stephan202 added chore A task not related to code (build, formatting, process, ...) and removed improvement labels Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @mohamedsamehsalah