Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Error Prone 2.23.0 -> 2.24.0 #935

Merged
merged 2 commits into from
Dec 23, 2023

Conversation

Picnic-Bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
com.google.errorprone:error_prone_annotations (source) compile minor 2.23.0 -> 2.24.0
com.google.errorprone:error_prone_core (source) minor 2.23.0 -> 2.24.0
com.google.errorprone:error_prone_test_helpers (source) compile minor 2.23.0 -> 2.24.0
com.google.errorprone:error_prone_core (source) compile minor 2.23.0 -> 2.24.0
com.google.errorprone:error_prone_check_api (source) compile minor 2.23.0 -> 2.24.0
com.google.errorprone:error_prone_annotation (source) compile minor 2.23.0 -> 2.24.0

Release Notes

google/error-prone (com.google.errorprone:error_prone_annotations)

v2.24.0: Error Prone 2.24.0

Compare Source

New checks:

Full Changelog: google/error-prone@v2.23.0...v2.24.0


  • If you want to rebase/retry this PR, check this box

@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Dec 22, 2023

cody-christmas-banner

The Java Platform team wishes you a happy festive period. Here is the suggested commit message:

Upgrade Error Prone 2.23.0 -> 2.24.0 (#935)

See:
- https://github.com/google/error-prone/releases/tag/v2.24.0
- https://github.com/google/error-prone/compare/v2.23.0...v2.24.0
- https://github.com/PicnicSupermarket/error-prone/compare/v2.23.0-picnic-1...v2.24.0-picnic-1
Renovate be like

image
Header generated and modified from Sweaterify.

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

2 similar comments
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the suggested commit message and added a commit to fix the build.

@rickie rickie added this to the 0.15.0 milestone Dec 22, 2023
@rickie
Copy link
Member

rickie commented Dec 22, 2023

A quick search didn't show any changes related to Refaster, (maybe good to check) but it would be nice to ensure that there are no incompatibilities 🤔. If we merge this, we skip a version of Error Prone and jump from 2.22.0 -> 2.24.0. Could be fine but just making sure we deliberately make the choice :).

@Stephan202
Copy link
Member

git diff v2.23.0..v2.24.0 --name-only shows no Refaster changes indeed. I think this confirms compatibility:

mvn clean install -Dverification.skip -DskipTests -Dversion.error-prone-orig=2.23.0 && mvn clean install -Pself-check

@rickie
Copy link
Member

rickie commented Dec 22, 2023

Would it be nice to add this as a note to Renovate such that it will give this as a note for next release as well? Maybe only for this repository though.

@rickie rickie force-pushed the renovate/version.error-prone-orig branch from 56d70fb to 77d1c27 Compare December 22, 2023 12:32
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Picnic-Bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@Stephan202
Copy link
Member

Would it be nice to add this as a note to Renovate such that it will give this as a note for next release as well? Maybe only for this repository though.

I've started work on a script to assess the full compatibility matrix. It's heavy WIP, would the idea is that it'd generate the input for a Jekyll page. This does of course require that we finally update the website branch. I'll look into that first, which is why I'll now merge this PR, as it should allow undoing some workarounds for google/error-prone#4157.

@Stephan202 Stephan202 changed the title Upgrade version.error-prone-orig 2.23.0 -> 2.24.0 Upgrade Error Prone 2.23.0 -> 2.24.0 Dec 23, 2023
@Stephan202 Stephan202 merged commit 967a446 into master Dec 23, 2023
16 checks passed
@Stephan202 Stephan202 deleted the renovate/version.error-prone-orig branch December 23, 2023 09:17
@Stephan202
Copy link
Member

I've started work on a script to assess the full compatibility matrix.

This turned into #938.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants