Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade actions/deploy-pages v3.0.1 -> v4.0.0 #932

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Upgrade actions/deploy-pages v3.0.1 -> v4.0.0 #932

merged 1 commit into from
Dec 22, 2023

Conversation

Picnic-Bot
Copy link
Contributor

@Picnic-Bot Picnic-Bot commented Dec 20, 2023 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
actions/deploy-pages action major v3.0.1 -> v4.0.0

Release Notes

actions/deploy-pages (actions/deploy-pages)

v4.0.0

Compare Source

Changelog

  • Deploy pages using artifact IDs @​konradpabjan (#​251)
  • This version requires the permission actions: read in the workflows which use it.

⚠️ This version of actions/deploy-pages is ONLY compatible with artifacts uploaded by either:

See details of all code changes since previous release.

⚠️ For use with products other than GitHub.com, such as GitHub Enterprise Server, please consult the compatibility table.

  • If you want to rebase/retry this PR, check this box

@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Dec 20, 2023 •
edited by rickie
Loading

cody-christmas-banner

The Java Platform team wishes you a happy festive period. Here is the suggested commit message:

Upgrade actions/deploy-pages v3.0.1 -> v4.0.0 (#932)

See:
- https://github.com/actions/deploy-pages/releases/tag/v4.0.0
Renovate be like

image
Header generated and modified from Sweaterify.

Stephan202
Stephan202 reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release notes indicate that this upgrade depends on #933 and a not-yet-opened PR to upgrade actions/upload-artifact to v4. But the release notes for #933 also say that it has an effective dependency on this upgrade. So let's wait for the actions/upload-artifact upgrade PR and merge the PRs in close succession.

@Stephan202 Stephan202 mentioned this pull request Dec 20, 2023
Merged
1 task
@Picnic-Bot Picnic-Bot force-pushed the renovate/actions-deploy-pages-4.x branch from de8410d to fff46f0 Compare December 21, 2023 02:04
Stephan202
Stephan202 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not-yet-opened PR to upgrade actions/upload-artifact

I was looking at an outdated branch; we did already upgrade that dependency: #921.

Let's merge #933 and this PR in close succession.

@Stephan202 Stephan202 added this to the 0.15.0 milestone Dec 21, 2023
rickie
rickie approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deal, will merge the two PRs.

@rickie rickie force-pushed the renovate/actions-deploy-pages-4.x branch from fff46f0 to cc06b3d Compare December 22, 2023 09:42
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rickie rickie merged commit 4d30329 into master Dec 22, 2023
16 checks passed
@rickie rickie deleted the renovate/actions-deploy-pages-4.x branch December 22, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
dependencies
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Picnic-Bot @Stephan202 @rickie