-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow static import of com.google.errorprone.{VisitorState,util.ASTHelpers}
members
#922
Conversation
Looks good. No mutations were possible for these changes. |
a5b99c1
to
78cfcb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and added a commit. At least one Error Prone check has a suggested fix in which an ASTHelpers
method is statically imported, so it's nice that this is now auto-fixed.
Suggested commit message:
Disallow static import of `com.google.errorprone.{VisitorState,util.ASTHelpers}` members (#922)
"com.google.errorprone.util.ASTHelpers", | ||
"com.google.errorprone.VisitorState", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match the GJF's import order:
"com.google.errorprone.util.ASTHelpers", | |
"com.google.errorprone.VisitorState", | |
"com.google.errorprone.VisitorState", | |
"com.google.errorprone.util.ASTHelpers", |
Looks good. No mutations were possible for these changes. |
…STHelpers}` members
78cfcb7
to
fd22854
Compare
Looks good. No mutations were possible for these changes. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Saw this during a code review 😄.
Probably we can add more from Error Prone later. I checked some other classes from Error Prone but these are clear improvements that we also have been discussing before. Therefore, I decided to start with these two.