Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dropwizard/metrics integration test #894

Closed
wants to merge 28 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4ec0678
Initial metrics integration test
oxkitsune Nov 23, 2023
11d02d4
Integration test script
oxkitsune Nov 23, 2023
d18dd8a
Use integration-test.sh in checkstyle
oxkitsune Nov 30, 2023
d7a3fbe
Use integration-test.sh relative to test dir
oxkitsune Nov 30, 2023
be6d3e5
Run metrics on java 17
oxkitsune Nov 30, 2023
36f8b01
run metrics
oxkitsune Dec 13, 2023
952451c
clarify reason for check exclusion
oxkitsune Dec 13, 2023
2ebd530
add `additional_src_directories` flag
oxkitsune Jan 10, 2024
b6bed86
fix checkstyle integration test script
oxkitsune Jan 10, 2024
3b2a0b4
add matrix to integration test workflow
oxkitsune Jan 10, 2024
713853d
suggestions
oxkitsune Jan 10, 2024
5825498
apply suggestions in init patch
oxkitsune Jan 11, 2024
97989c6
trigger integration-test action
oxkitsune Jan 11, 2024
4dcfb10
temporarily remove condition
oxkitsune Jan 11, 2024
79931df
disable new checks as they cause errors
oxkitsune Jan 24, 2024
4dafc7e
Post-rebase fix
rickie Feb 13, 2024
dddb602
Rename metrics files to drop the version
rickie Feb 13, 2024
0417783
Style improvements
rickie Feb 13, 2024
75eb8d2
Typo
rickie Feb 13, 2024
b9836c6
sync metrics
oxkitsune Mar 1, 2024
78cac86
Only run on GH comment
rickie Mar 6, 2024
1ff1d57
Try to trigger metrics
rickie Mar 6, 2024
51ec7bc
Try to run both variants
rickie Mar 6, 2024
ee00181
Dont analyse generated files
rickie Mar 6, 2024
8b4cba4
Fix metrics init patch
oxkitsune Mar 20, 2024
cc69b87
Try different refaster name patterns
oxkitsune Mar 20, 2024
f793c73
Merge `master` in this branch
rickie Nov 14, 2024
1ac65e9
Fix missed merge conflicts
rickie Nov 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions .github/workflows/run-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,26 @@
# against the project, using the code found on the pull request branch.
# XXX: Generalize this to a matrix build of multiple integration tests,
# possibly using multiple JDK or OS versions.
# XXX: Investigate whether the comment can specify which integration tests run
# run. See this example of a dynamic build matrix:
# XXX: Investigate whether the comment can specify which integration tests run.
# See this example of a dynamic build matrix:
# https://docs.github.com/en/actions/learn-github-actions/expressions#example-returning-a-json-object
name: "Integration tests"
on:
pull_request:
branches: [ master ]
issue_comment:
types: [ created ]
permissions:
contents: read
jobs:
run-integration-tests:
name: On-demand integration test
if: |
github.event.issue.pull_request && contains(github.event.comment.body, '/integration-test')
runs-on: ubuntu-24.04
# if: github.event.issue.pull_request && contains(github.event.comment.body, '/integration-test')
# XXX: Configure permissions.
strategy:
matrix:
integration-test: [ "metrics", "checkstyle" ]
name: On-demand integration test
steps:
- name: Install Harden-Runner
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
Expand All @@ -35,19 +40,20 @@ jobs:
- name: Check out code and set up JDK and Maven
uses: s4u/setup-maven-action@382542f77617f34e56bf83868920a4d45b7451e7 # v1.16.0
with:
# checkout-ref: "refs/pull/894/head"
checkout-ref: "refs/pull/${{ github.event.issue.number }}/head"
java-version: 17.0.13
java-distribution: temurin
maven-version: 3.9.9
- name: Install project to local Maven repository
run: mvn -T1C install -DskipTests -Dverification.skip
- name: Run integration test
run: xvfb-run ./integration-tests/checkstyle.sh "${{ runner.temp }}/artifacts"
run: xvfb-run "./integration-tests/${{ matrix.integration-test }}.sh" "${{ runner.temp }}/artifacts"
- name: Upload artifacts on failure
if: ${{ failure() }}
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
with:
name: integration-test-checkstyle
name: "integration-test-${{ matrix.integration-test }}"
path: "${{ runner.temp }}/artifacts"
- name: Remove installed project artifacts
run: mvn dependency:purge-local-repository -DmanualInclude='${project.groupId}' -DresolutionFuzziness=groupId
Empty file.
Loading
Loading