Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ConstantsFormat Refaster rule #883

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Nov 13, 2023

Suggested commit message:

Introduce `ConstantsFormat` Refaster rule (#883)

@Stephan202 Stephan202 added this to the 0.15.0 milestone Nov 13, 2023
Copy link

Looks good. All 2 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.StringJoin 0 1
🎉tech.picnic.errorprone.refaster.test.RefasterRuleCollection 0 1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie self-requested a review November 26, 2023 14:35
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@@ -52,4 +54,16 @@ BugCheckerRefactoringTestHelper after(
return helper.addInputLines(path, source).expectUnchanged();
}
}

static final class ConstantsFormat {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a Javadoc? Will push a proposal.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion LGTM 👍

Copy link

Looks good. All 2 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.StringJoin 0 1
🎉tech.picnic.errorprone.refaster.test.RefasterRuleCollection 0 1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the sschroevers/introduce-ConstantsFormat-rule branch from 87e0acf to 2afcf93 Compare November 27, 2023 10:40
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link

Looks good. All 2 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.StringJoin 0 1
🎉tech.picnic.errorprone.refaster.test.RefasterRuleCollection 0 1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@rickie rickie merged commit 5618de4 into master Nov 27, 2023
17 checks passed
@rickie rickie deleted the sschroevers/introduce-ConstantsFormat-rule branch November 27, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants