Disallow static import of BugCheckerRefasctoringTestHelper.TestMode#TEXT_MATCH
#862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Stephan202
force-pushed
the
rossendrijver/nonstaticimport_textmatch
branch
from
d1b7d45 to
50d6342
Compare
Stephan202
approved these changes
Oct 29, 2023
| @@ -78,6 +78,7 @@ public final class NonStaticImport extends BugChecker implements CompilationUnit | |||
| static final ImmutableSetMultimap<String, String> NON_STATIC_IMPORT_CANDIDATE_MEMBERS = | |||
| ImmutableSetMultimap.<String, String>builder() | |||
| .put("com.google.common.base.Predicates", "contains") | |||
| .put("com.google.errorprone.BugCheckerRefactoringTestHelper.TestMode", "TEXT_MATCH") | |||
There was a problem hiding this comment.
It's not like we do want to statically import AST_MATCH, so I suppose we can extend NON_STATIC_IMPORT_CANDIDATE_TYPES instead.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
cernat-catalin
approved these changes
Oct 30, 2023
rickie
force-pushed
the
rossendrijver/nonstaticimport_textmatch
branch
from
50d6342 to
f2a09ed
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remembered we wanted to fix this one some time ago.
However, it does a non 100% optimal fix for this specific case as it rewrites it to:
Which can be easily fixed by removing the qualifier, but I'd say flagging this is an improvement for now.
Didn't add a test as we already extensively test the members in the
identificationtest.Suggested commit message: