Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable test for ClassRules rule collection #826

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Enable test for ClassRules rule collection #826

merged 1 commit into from
Oct 10, 2023

Conversation

rickie
Copy link
Member

@rickie rickie commented Oct 9, 2023

Based on something @benhalasi flagged in a different PR: #771 (comment).

Struggling with finding the best label for this PR, suggestions?

@rickie rickie added this to the 0.15.0 milestone Oct 9, 2023
@rickie rickie requested review from Stephan202 and benhalasi October 9, 2023 06:52
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 added the chore A task not related to code (build, formatting, process, ...) label Oct 9, 2023
@Stephan202 Stephan202 force-pushed the rossendrijver/class_fix branch from 9f810d8 to 214a228 Compare October 9, 2023 11:10
Stephan202
Stephan202 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose chore works. Suggested commit message:

Fix and enable `ClassRules` Refaster rule collection tests (#826)

Rebased.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rickie rickie merged commit b492a4a into master Oct 10, 2023
17 checks passed
@rickie rickie deleted the rossendrijver/class_fix branch October 10, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhalasi benhalasi benhalasi approved these changes

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rickie @Stephan202 @benhalasi