Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce FluxEmpty Refaster rule #815

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Introduce FluxEmpty Refaster rule #815

merged 3 commits into from
Oct 9, 2023

Conversation

Venorcis
Copy link
Contributor

@Venorcis Venorcis commented Oct 6, 2023

This is mainly intended to prevent Flux.just(), preferring the more expressive Flux.empty(), but while there why not prevent the other vararg constructors from being used without arguments 🤷🏻‍♂️

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie requested review from rickie and Stephan202 October 6, 2023 19:39
@rickie rickie added this to the 0.15.0 milestone Oct 6, 2023
rickie
rickie approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements @Venorcis 🚀 !

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java Outdated Show resolved Hide resolved
error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Stephan202
Stephan202 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased and added a commit. I.c.w. #744 we could rewrite even more cases. (But we would be entering "just write a BugChecker" territory.

Nice addition!

Updated suggested commit message:

Introduce `Flux{Empty,Just}` Refaster rules (#815)

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie
Copy link
Member

rickie commented Oct 8, 2023

Will take a look at the new changes Monday and merge it 👍🏻.

rickie
rickie approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't review all the extra operators in too much detail, but overall LGTM!

@rickie rickie force-pushed the vkoeman/flux-empty branch from 6075395 to effcb21 Compare October 9, 2023 09:21
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rickie rickie merged commit 9ada078 into master Oct 9, 2023
17 checks passed
@rickie rickie deleted the vkoeman/flux-empty branch October 9, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
new feature
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Venorcis @rickie @Stephan202