Introduce {Mono,Flux}OfType Refaster rules
#810
Conversation
werli
changed the title
{Mono,Flux}OfType Refaster rules
|
Looks good. No mutations were possible for these changes. |
| Refaster.<S>clazz()::isInstance, | ||
| x -> Refaster.<S>clazz().isAssignableFrom(x.getClass()))) |
There was a problem hiding this comment.
We can introduce a separate rule to prefer the first over the second. (I have this change locally already, but need to leave the train now 😅.)
Stephan202
force-pushed
the
werli/publisher-typeof
branch
from
37f7f17 to
a781fb2
Compare
| Refaster.<S>clazz()::isInstance, | ||
| x -> Refaster.<S>clazz().isAssignableFrom(x.getClass()))) |
| Mono<S> before(Mono<T> mono) { | ||
| return mono.filter( | ||
| Refaster.anyOf( | ||
| Refaster.<S>clazz()::isInstance, |
There was a problem hiding this comment.
Instead of Refaster.<S>clazz() we can use a Class<S> clazz parameter, in which case non-literal class references are also captured.
|
Looks good. No mutations were possible for these changes. |
|
|
||
| @AfterTemplate | ||
| Mono<S> after(Mono<T> mono, Class<S> clazz) { | ||
| return mono.ofType(clazz); |
There was a problem hiding this comment.
nice, didn't know this existed, will rewrite some uses in our code 😄 🚀
rickie
force-pushed
the
werli/publisher-typeof
branch
from
a781fb2 to
f9f7d25
Compare
|
Looks good. No mutations were possible for these changes. |
rickie
force-pushed
the
werli/publisher-typeof
branch
from
f9f7d25 to
788d555
Compare
|
Looks good. No mutations were possible for these changes. |
|
Kudos, SonarCloud Quality Gate passed!
|
Since semantically this should be equivalent.
Suggested commit message: