Upgrade Error Prone 2.21.1 -> 2.22.0 #800

Picnic-Bot · 2023-09-22T01:07:11Z

This PR contains the following updates:

Package	Type	Update	Change
com.google.errorprone:error_prone_annotations (source)	compile	minor	`2.21.1` -> `2.22.0`
com.google.errorprone:error_prone_core (source)		minor	`2.21.1` -> `2.22.0`
com.google.errorprone:error_prone_test_helpers (source)	compile	minor	`2.21.1` -> `2.22.0`
com.google.errorprone:error_prone_core (source)	compile	minor	`2.21.1` -> `2.22.0`
com.google.errorprone:error_prone_check_api (source)	compile	minor	`2.21.1` -> `2.22.0`
com.google.errorprone:error_prone_annotation (source)	compile	minor	`2.21.1` -> `2.22.0`

Release Notes

google/error-prone (com.google.errorprone:error_prone_annotations)

`v2.22.0`: Error Prone 2.22.0

Compare Source

We are considering raising the minimum supported JDK from JDK 11 to JDK 17 in a future release of Error Prone, see #3803. Note that using a newer JDK version to run javac during the build doesn't prevent building code that is deployed to earlier versions, for example it's supported to use the JDK 17 javac and pass --release 11 to compile Java 11 code that is deployed to a JDK 11 runtime. If you have feedback, please comment on #3803.

New checks:

ClosingStandardOutputStreams: Prevents accidentally closing System.{out,err} with try-with-resources
TruthContainsExactlyElementsInUsage: containsExactly is preferred over containsExactlyElementsIn when creating new iterables
UnnecessaryAsync: detects unnecessary use of async primitives in local (and hence single-threaded) scopes
ReturnAtTheEndOfVoidFunction: detects unnecessary return statements at the end of void functions
MultimapKeys: Suggests using keySet() instead of iterating over Multimap.keys(), which does not collapse duplicates

Bug fixes and improvements:

Don't complain about literal IP addresses in AddressSelection (google/error-prone@44b6552)
Prevent SuggestedFixes#renameMethod from modifying return type declaration (#4043)
Fix UnusedVariable false positives for private record parameters (#2713)
When running in conservative mode, no longer assume that implementations of Map.get, etc. return null (#2910)
CanIgnoreReturnValueSuggester: Support additional exempting method annotations (#4009)
UnusedVariable: exclude junit5's @RegisterExtension (#3892)
Support running all available patch checks (#947)
Upgrade java-diff-utils 4.0 -> 4.12 (#4081)
Flag unused Refaster template parameters (#4060)
Support @SuppressWarnings("all") (#4065)
Prevent Refaster UMemberSelect from matching method parameters (#2456)
MissingDefault : Don't require // fall out comments on expression switches (#2709)
Skip UnnecessaryLambda findings for usages in enhanced for loops (#2518)
Fix bug where nested MissingBraces violations' suggested fixes result in broken code (#3797)
Add support for specifying exemptPrefixes/exemptNames for UnusedVariable via flags (#2753)
UnusedMethod: Added exempting variable annotations (#2881)

Full Changelog: google/error-prone@v2.21.1...v2.22.0

If you want to rebase/retry this PR, check this box

Picnic-Bot · 2023-09-22T01:07:35Z

Suggested commit message:

Upgrade Error Prone 2.21.1 -> 2.22.0 (#800)

See:
- https://github.com/google/error-prone/releases/tag/v2.22.0
- https://github.com/google/error-prone/compare/v2.21.1...v2.22.0
- https://github.com/PicnicSupermarket/error-prone/compare/v2.21.1-picnic-1...v2.22.0-picnic-1

github-actions · 2023-09-22T01:09:33Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2023-09-22T07:45:00Z

Looks good. All 5 mutations in this change were killed.

class	surviving	killed
🎉`tech.picnic.errorprone.bugpatterns.LexicographicalAnnotationAttributeListing`	0	2
🎉`tech.picnic.errorprone.bugpatterns.util.Flags`	0	3

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2023-09-22T09:50:56Z

Looks good. All 5 mutations in this change were killed.

class	surviving	killed
🎉`tech.picnic.errorprone.bugpatterns.LexicographicalAnnotationAttributeListing`	0	2
🎉`tech.picnic.errorprone.bugpatterns.util.Flags`	0	3

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Stephan202

Added some commits.

Stephan202 · 2023-09-22T10:02:57Z

.../main/java/tech/picnic/errorprone/bugpatterns/LexicographicalAnnotationAttributeListing.java

-        flags.getList(INCLUDED_ANNOTATIONS_FLAG), excludedAnnotations(flags));
+        flags.get(INCLUDED_ANNOTATIONS_FLAG).isPresent()
+            ? Optional.of(flags.getListOrEmpty(INCLUDED_ANNOTATIONS_FLAG))
+            : Optional.empty(),
+        excludedAnnotations(flags));


This is not great, but alas.

Picnic-Bot · 2023-09-23T01:02:59Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

github-actions · 2023-10-04T10:39:59Z

Looks good. All 5 mutations in this change were killed.

class	surviving	killed
🎉`tech.picnic.errorprone.bugpatterns.LexicographicalAnnotationAttributeListing`	0	2
🎉`tech.picnic.errorprone.bugpatterns.util.Flags`	0	3

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

See: - https://github.com/google/error-prone/releases/tag/v2.22.0

sonarqubecloud · 2023-10-04T11:47:57Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

github-actions · 2023-10-04T11:48:13Z

Looks good. All 5 mutations in this change were killed.

class	surviving	killed
🎉`tech.picnic.errorprone.bugpatterns.LexicographicalAnnotationAttributeListing`	0	2
🎉`tech.picnic.errorprone.bugpatterns.util.Flags`	0	3

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie

Tweaked suggested commit message to be similar to previous commits.

Picnic-Bot added the dependencies label Sep 22, 2023

Picnic-Bot requested review from rickie and Stephan202 September 22, 2023 01:07

Stephan202 approved these changes Sep 22, 2023

View reviewed changes

Stephan202 added this to the 0.14.0 milestone Sep 22, 2023

Stephan202 force-pushed the renovate/version.error-prone-orig branch from 463fc28 to e1399c6 Compare October 4, 2023 10:36

Picnic-Bot and others added 3 commits October 4, 2023 13:45

Upgrade version.error-prone-orig 2.21.1 -> 2.22.0

71c189f

See: - https://github.com/google/error-prone/releases/tag/v2.22.0

Fix build

5e46612

Drop obsolete flags

ac6cbbc

rickie force-pushed the renovate/version.error-prone-orig branch from e1399c6 to ac6cbbc Compare October 4, 2023 11:45

rickie approved these changes Oct 4, 2023

View reviewed changes

rickie merged commit ef75b80 into master Oct 4, 2023
17 checks passed

rickie deleted the renovate/version.error-prone-orig branch October 4, 2023 12:43

Stephan202 changed the title ~~Upgrade version.error-prone-orig 2.21.1 -> 2.22.0~~ Upgrade Error Prone 2.21.1 -> 2.22.0 Oct 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Error Prone 2.21.1 -> 2.22.0 #800

Upgrade Error Prone 2.21.1 -> 2.22.0 #800

Picnic-Bot commented Sep 22, 2023 •

edited by Stephan202

Loading

Picnic-Bot commented Sep 22, 2023 •

edited by rickie

Loading

github-actions bot commented Sep 22, 2023

github-actions bot commented Sep 22, 2023

github-actions bot commented Sep 22, 2023

Stephan202 left a comment

Stephan202 Sep 22, 2023

Picnic-Bot commented Sep 23, 2023

github-actions bot commented Oct 4, 2023

sonarqubecloud bot commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

rickie left a comment

Upgrade Error Prone 2.21.1 -> 2.22.0 #800

Upgrade Error Prone 2.21.1 -> 2.22.0 #800

Conversation

Picnic-Bot commented Sep 22, 2023 • edited by Stephan202 Loading

Release Notes

v2.22.0: Error Prone 2.22.0

Picnic-Bot commented Sep 22, 2023 • edited by rickie Loading

github-actions bot commented Sep 22, 2023

github-actions bot commented Sep 22, 2023

github-actions bot commented Sep 22, 2023

Stephan202 left a comment

Choose a reason for hiding this comment

Stephan202 Sep 22, 2023

Choose a reason for hiding this comment

Picnic-Bot commented Sep 23, 2023

Edited/Blocked Notification

github-actions bot commented Oct 4, 2023

sonarqubecloud bot commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

rickie left a comment

Choose a reason for hiding this comment

Picnic-Bot commented Sep 22, 2023 •

edited by Stephan202

Loading

`v2.22.0`: Error Prone 2.22.0

Picnic-Bot commented Sep 22, 2023 •

edited by rickie

Loading