Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop ScheduledTransactionTrace check #788

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Drop ScheduledTransactionTrace check #788

merged 1 commit into from
Oct 4, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Sep 11, 2023 •
edited
Loading

Suggested commit message:

Drop `ScheduledTransactionTrace` check (#788)

As well as any other references to New Relic.

❗ Before merging this, we should validate that Datadog does indeed collect traces for @Scheduled transactions out of the box.

@Stephan202 Stephan202 added this to the 0.14.0 milestone Sep 11, 2023
@Stephan202 Stephan202 mentioned this pull request Sep 11, 2023
Merged
1 task
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 requested a review from rickie September 26, 2023 07:23
@Stephan202 Stephan202 force-pushed the sschroevers/drop-new-relic-support branch from 68a903b to 5e053f7 Compare October 3, 2023 15:21
@Stephan202
Copy link
Member Author

Rebased and resolved conflict.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie modified the milestones: 0.14.0, 0.15.0 Oct 4, 2023
mohamedsamehsalah
mohamedsamehsalah approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the validating that Datadog does indeed collect traces for @scheduled transactions out of the box comment.

@rickie rickie modified the milestones: 0.15.0, 0.14.0 Oct 4, 2023
@rickie rickie force-pushed the sschroevers/drop-new-relic-support branch from 5e053f7 to c931841 Compare October 4, 2023 12:44
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 @rickie
Drop ScheduledTransactionTrace check
ebc77f7 
As well as any other references to New Relic.
@rickie rickie force-pushed the sschroevers/drop-new-relic-support branch from c931841 to ebc77f7 Compare October 4, 2023 12:53
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rickie rickie merged commit 9a77a3f into master Oct 4, 2023
17 checks passed
@rickie rickie deleted the sschroevers/drop-new-relic-support branch October 4, 2023 13:30
@Stephan202
Copy link
Member Author

Before merging this, we should validate that Datadog does indeed collect traces for @Scheduled transactions out of the box.

While I didn't test this in production, the agent source code does have a test case for this. So I expect this'll work fine. If not, we'll review how to deal with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
deprecation
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @mohamedsamehsalah