Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow autovalue.shaded.* imports #774

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Disallow autovalue.shaded.* imports #774

merged 1 commit into from
Oct 2, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Sep 2, 2023 •
edited
Loading

Suggested commit message:

Disallow `autovalue.shaded.*` imports (#774)

@Stephan202 Stephan202 added this to the 0.14.0 milestone Sep 2, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Oct 2, 2023
rickie
rickie approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What specific situation made you open this PR 😄?

@rickie
Copy link
Member

rickie commented Oct 2, 2023

@mohamedsamehsalah Do you have time to review this one :)?

@Stephan202
Copy link
Member Author

What specific situation made you open this PR 😄?

Don't remember for sure, but probably an automatic import of some autovalue.shaded.com.google.common.** type.

@mohamedsamehsalah
Copy link
Contributor

@rickie @mohamedsamehsalah Do you have time to review this one :)?

Done ✅

@rickie rickie force-pushed the sschroevers/disallow/autovalue-shaded-types branch from 3f43e26 to 9a104c6 Compare October 2, 2023 15:47
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rickie rickie merged commit 26bc7e6 into master Oct 2, 2023
17 checks passed
@rickie rickie deleted the sschroevers/disallow/autovalue-shaded-types branch October 2, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @mohamedsamehsalah